feat: api docs for envs / apps / access#213
Merged
Merged
Conversation
Deploying phase-docs with
|
| Latest commit: |
368aa06
|
| Status: | ⚡️ Build in progress... |
7 tasks
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
…, owner immutability, identity_key preconditions, role delete codes, invite validation, error status codes)
…field, use camelCase in role response examples, link to access-control/roles for resource list, drop user-facing 'soft-delete' language
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
rohan-chaturvedi
force-pushed
the
feat--apis--envs-apps-access
branch
from
660525f to
1f1dc26
Compare
… declarative access endpoints
…scoped visibility
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
…nt folder field, drop trailing-space Bearer token, replace io/ioutil with io
…ing and revoking additional SA tokens
…T /access/ section
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
… to expires_in (seconds)
…expires_in (priority + ISO-8601 with timezone)
…/teams/roles/members/invites
…oken{id,...} on service-account create
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
…s, point Members page to Invites for new-member flow
… requires invitee identity key (post-acceptance only)
Signed-off-by: rohan <rohan.chaturvedi@protonmail.com>
…h backend
After re-validation against `phasehq/console@api--apps-envs-accounts`:
- Roles POST/PUT examples shipped `"global_access": false`, but the
server rejects any `global_access` / `globalAccess` under `permissions`
with `400 Bad Request` (`backend/api/views/roles.py:58`, allowed_keys =
{"permissions", "app_permissions"}). Removed the rejected key from
both cURL + Python examples and rewrote the Required-fields /
PUT-body descriptions to match. The Note block at the top of the
page (line 60) already said only `permissions` + `app_permissions`
are accepted, so the page is now internally consistent.
- DELETE Service Account paragraph said revoked tokens return
`403 Forbidden`. Actual behaviour is `401 Unauthorized` with
`{"error": "Token expired or deleted"}`
(`backend/api/auth.py:88-89` raises `AuthenticationFailed`, which DRF
maps to 401). Matches the sibling DELETE Token paragraph and
`errors.mdx` line 40.
Related: phasehq/console#798, PH-618
4 tasks
…fixes docs(rest): align Roles 'global_access' usage and DELETE-SA token-invalidation status with backend
nimish-ks
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
companion pr for phasehq/console#798