Skip to content

Update Resultset.php: add @implements ArrayAccess<TKey, TValue> - #111

Closed
ryinner wants to merge 1 commit into
phalcon:masterfrom
ryinner:patch-1
Closed

Update Resultset.php: add @implements ArrayAccess<TKey, TValue>#111
ryinner wants to merge 1 commit into
phalcon:masterfrom
ryinner:patch-1

Conversation

@ryinner

@ryinner ryinner commented Apr 7, 2025

Copy link
Copy Markdown

add generic support for ArrayAccess<TKey, TValue>

add generic support for ArrayAccess<TKey, TValue>
@niden

niden commented Apr 21, 2025

Copy link
Copy Markdown
Member

@ryinner The stubs here will be overwritten after the next release. If you want, you can issue your PR in the cphalcon repository and target the 5.0.x branch. You can add the same line in Resultset.zep and it will be included in the stubs.

Thanks

@ryinner

ryinner commented Apr 22, 2025

Copy link
Copy Markdown
Author

@ryinner The stubs here will be overwritten after the next release. If you want, you can issue your PR in the cphalcon repository and target the 5.0.x branch. You can add the same line in Resultset.zep and it will be included in the stubs.

Thanks

Thanks for your answer. I create new pr for cphalcon.

@niden

niden commented Apr 22, 2025

Copy link
Copy Markdown
Member

Closing in favor of phalcon/cphalcon#16759

@niden niden closed this Apr 22, 2025
@niden niden added this to Phalcon v5 Apr 22, 2025
@niden niden moved this to Unverified - Wont Fix - Duplicates in Phalcon v5 Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Unverified - Wont Fix - Duplicates

Development

Successfully merging this pull request may close these issues.

2 participants