Skip to content

Vault backend integration#958

Merged
levkk merged 6 commits into
pgdogdev:mainfrom
larrywax:vault-backend-integration
Jun 25, 2026
Merged

Vault backend integration#958
levkk merged 6 commits into
pgdogdev:mainfrom
larrywax:vault-backend-integration

Conversation

@larrywax

@larrywax larrywax commented May 4, 2026

Copy link
Copy Markdown
Contributor

Draft implementation as discussed in #938

@CLAassistant

CLAassistant commented May 4, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@larrywax larrywax mentioned this pull request May 4, 2026
Comment thread pgdog-config/src/vault.rs Outdated
Comment thread pgdog/src/backend/auth/vault/api.rs Outdated
Comment thread pgdog/src/main.rs Outdated
@levkk

levkk commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Really cool, thanks for implementing this! I'm still reviewing, will get back to you with more comments if any asap.

Comment thread pgdog/src/backend/auth/vault/mod.rs Outdated
Comment thread pgdog/src/backend/auth/vault/mod.rs Outdated
Comment thread pgdog/src/backend/auth/vault/mod.rs Outdated
Comment thread pgdog/src/main.rs Outdated
@levkk

levkk commented May 5, 2026

Copy link
Copy Markdown
Collaborator

Great start. A few comments on style and one important architectural issue: the vault credentials are loaded on boot only, but pgdog config is dynamic and can be reloaded without restarting, I think the current implementation will reset the credentials when this happens.

Fixed my incorrect merge conflict fix in 884f14e6391a69b11b8da22ca074ca62e5e36190 (you should be able to cherry-pick it from #960).

@larrywax

larrywax commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

Great start. A few comments on style and one important architectural issue: the vault credentials are loaded on boot only, but pgdog config is dynamic and can be reloaded without restarting, I think the current implementation will reset the credentials when this happens.

Fixed my incorrect merge conflict fix in 884f14e6391a69b11b8da22ca074ca62e5e36190 (you should be able to cherry-pick it from #960).

Ah I see, was not aware of it. Makes sense, thanks!

@larrywax larrywax force-pushed the vault-backend-integration branch from 3d52f90 to d3ac996 Compare May 7, 2026 12:30
Comment thread pgdog/src/backend/auth/vault/mod.rs Outdated
@larrywax larrywax force-pushed the vault-backend-integration branch from d3ac996 to 4c76f84 Compare June 10, 2026 13:25
Comment thread pgdog-config/src/users.rs Outdated
Comment thread pgdog/src/backend/auth/azure_workload_identity.rs Outdated
Comment thread pgdog/src/backend/auth/vault.rs Outdated
Comment thread pgdog/src/backend/pool/inner.rs Outdated
Comment thread pgdog/src/backend/pool/inner.rs
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

@levkk levkk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good!

@larrywax larrywax marked this pull request as ready for review June 25, 2026 13:29
@levkk

levkk commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Just need one pass with the formatter and we're good to go.

@larrywax

Copy link
Copy Markdown
Contributor Author

Just need one pass with the formatter and we're good to go.

Ops, my bad :D should be good now

@levkk levkk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@levkk levkk merged commit b86c265 into pgdogdev:main Jun 25, 2026
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants