Vault backend integration#958
Conversation
|
Really cool, thanks for implementing this! I'm still reviewing, will get back to you with more comments if any asap. |
|
Great start. A few comments on style and one important architectural issue: the vault credentials are loaded on boot only, but pgdog config is dynamic and can be reloaded without restarting, I think the current implementation will reset the credentials when this happens. Fixed my incorrect merge conflict fix in |
Ah I see, was not aware of it. Makes sense, thanks! |
3d52f90 to
d3ac996
Compare
d3ac996 to
4c76f84
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Just need one pass with the formatter and we're good to go. |
Ops, my bad :D should be good now |
Draft implementation as discussed in #938