Skip to content

V25 250#39

Open
mason-sharp wants to merge 2 commits into
mainfrom
v25-250
Open

V25 250#39
mason-sharp wants to merge 2 commits into
mainfrom
v25-250

Conversation

@mason-sharp
Copy link
Copy Markdown
Member

Use 3 digit semantic versioning; change from 2.5 to 2.5.0.

Add changelog.md file for changes since 2.4.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR releases version 2.5.0 of the Snowflake extension with PostgreSQL 18 support and sequence conversion fixes. Version metadata is updated across control and build files, the migration script includes sequence repair logic for prior conversions, tests validate the repair, and comprehensive release notes document all changes.

Changes

Snowflake Extension 2.5.0 Release

Layer / File(s) Summary
Version Configuration Update
snowflake.control, Makefile
Extension version updated from 2.5 to 2.5.0 in control file and migration script reference in build metadata.
Sequence Conversion and Repair Migration
snowflake--2.4--2.5.0.sql, sql/repair.sql
Migration script snowflake--2.4--2.5.0.sql re-installs the convert_sequence_to_snowflake() function with enhanced handling and adds a one-shot repair DO block that scans pg_sequences to fix sequences with outdated MAXVALUE values to bigint bounds. Test repair.sql validates the automatic repair on upgrade completes and sequences have correct MAXVALUE.
Release Documentation and Navigation
docs/changelog.md, mkdocs.yml
Changelog entry documents PG18 support, three-digit versioning scheme adoption, Snowflake sequence dump/restore fixes, and security/CI hardening updates. MkDocs navigation updated with new "Changelog" entry.

Poem

🐰 A bunny hops through version trees,
From 2.5 to 2.5.0, if you please!
Sequences repair with maxval might,
PostgreSQL 18 shines so bright,
Changelog sings of what was done—
Release notes greet the rising sun! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'V25 250' is vague and cryptic, using abbreviations that don't clearly convey the main change of adopting 3-digit semantic versioning and adding a changelog. Use a clearer title such as 'Use 3-digit semantic versioning for v2.5.0' or 'Adopt semantic versioning and add changelog' to better describe the primary changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description clearly and concisely explains the main changes: switching to 3-digit semantic versioning (2.5 to 2.5.0) and adding a changelog file documenting changes since 2.4.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v25-250

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mason-sharp mason-sharp requested a review from ibrarahmad June 5, 2026 00:16
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 1 high

Results:
1 new issue

Category Results
Compatibility 1 high

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/changelog.md`:
- Line 26: Update the changelog entry that currently reads "Fixed the SQL
command used to convert sequences to Snowflake" to explicitly state what was
wrong and what changed: mention the exact symptom (e.g., failing conversion,
wrong identifier quoting, incorrect CREATE/ALTER syntax, or wrong schema
qualification), describe the corrective change (e.g., corrected SQL to use
proper quoting and CREATE SEQUENCE ... semantics or adjusted schema-qualified
names), and include a brief before/after description or a short example of the
old vs. new SQL so users can see the exact fix; replace the vague sentence with
this clarified explanation referencing the original phrase "Fixed the SQL
command used to convert sequences to Snowflake."

In `@Makefile`:
- Line 21: The Makefile's DATA list includes only the upgrade script
snowflake--2.4--2.5.0.sql but is missing the required base installation script
snowflake--2.5.0.sql; add a new file named snowflake--2.5.0.sql containing the
extension’s base installation SQL and then update the Makefile DATA list if
necessary to reference both snowflake--2.5.0.sql and snowflake--2.4--2.5.0.sql
(ensure the new file is committed alongside the existing upgrade script so the
release/installation can find snowflake--2.5.0.sql).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15f7801f-61a7-4363-b508-74499f8258b4

📥 Commits

Reviewing files that changed from the base of the PR and between 9380d25 and 52a5167.

⛔ Files ignored due to path filters (1)
  • expected/repair.out is excluded by !**/*.out
📒 Files selected for processing (6)
  • Makefile
  • docs/changelog.md
  • mkdocs.yml
  • snowflake--2.4--2.5.0.sql
  • snowflake.control
  • sql/repair.sql

Comment thread docs/changelog.md
Comment thread Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant