Keep Graph::getNumEdge consistent with vertex adjacency lists - #114
Open
gaaraujo wants to merge 1 commit into
Open
Keep Graph::getNumEdge consistent with vertex adjacency lists#114gaaraujo wants to merge 1 commit into
gaaraujo wants to merge 1 commit into
Conversation
Self-loops were rejected by Vertex::addEdge but still counted as newly added edges, inflating numEdge and breaking nnz = V + 2E under Transformation when element IDs repeat an equation.
gaaraujo
force-pushed
the
fix/graph-self-loops
branch
from
August 9, 2026 23:46
4e202c4 to
34be23e
Compare
claudioperez
added
the
Upstream Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vertex::addEdgerejects self-loops but still returned0(i.e. “added”), soGraphincreasednumEdgewithout growing either adjacency list. That created a mismatch between the expected number of nonzeros fromnnz = numVertices + 2*numEdgesand the count from looping over the adjacency lists. Under the Transformation constraint handler this shows up when an element’s condensed IDs repeat an equation and the DOF graph asks foraddEdge(i,i).