test(e2e): unify testagent-lifecycle waits on a shared 15s timeout - #99
Draft
paultyng wants to merge 2 commits into
Draft
test(e2e): unify testagent-lifecycle waits on a shared 15s timeout#99paultyng wants to merge 2 commits into
paultyng wants to merge 2 commits into
Conversation
The MCP-connect readiness and session-exit status waits were duplicated across specs with a 10s literal, while ac3607a had already bumped dashboard's equivalent wait to 15s ("MCP connect latency on loaded CI runners is the dominant flake driver"). The un-propagated 10s copies in idea-session/demos/claude-sync/sidebar-collapse time out under CI load — the recurring test-ui flake since ~2026-07-07. Extract AGENT_LIFECYCLE_TIMEOUT_MS (15s) in ptyCapture.ts and route all 11 readiness/exit waits through it so the value can't drift back down. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
review-all C1: screenshots.spec.ts's mcp-connected buffer-scan was left at 10s — same flake class as the others, and it runs in CI test:ui (no testIgnore). Route it through AGENT_LIFECYCLE_TIMEOUT_MS too. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-ui has flaked on
mainsince ~2026-07-07 on 10s readiness/exit waits that time out on loaded CI runners.ac3607aalready bumped dashboard's equivalent wait 5s→15s ("MCP connect latency on loaded CI runners is the dominant flake driver") but never propagated it.Extract
AGENT_LIFECYCLE_TIMEOUT_MS(15s) inptyCapture.tsand route all 11mcp connected:/ session-exit waits through it (idea-session, demos, claude-sync, sidebar-collapse) so the value can't drift back below the proven threshold.Follow-ups (not this PR):
command-palette.spec.ts:124— separate navigation-timing flake, not MCP-connect.Connect()has no retry: a transient MCPinitializefailure becomes a hard timeout (upstreampaultyng/testagent).🤖 Generated with Claude Code