gcc 14.2.0 optimization tolerant - #342
Open
dmisol wants to merge 1 commit into
Open
Conversation
Comment on lines
+26
to
+27
| volatile bool success = false; | ||
| volatile bool done = false; |
Owner
There was a problem hiding this comment.
The variables should still be static:
Suggested change
| volatile bool success = false; | |
| volatile bool done = false; | |
| static volatile bool success = false; | |
| static volatile bool done = false; |
Owner
|
Thanks, it would also be good to fix the global booleans in other tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when using gcc (Ubuntu 14.2.0-19ubuntu2) 14.2.0, test continued gathering candidates, ignoring 'success' variable.