Open
Conversation
added 2 commits
May 4, 2024 14:22
…chController.java"
…nController.java"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request from patched fixes 4 issues.
Removed Spring Expression Language (SpEL) parsing and evaluation
The diff removes the import statements for Spring's Expression and ExpressionParser classes, as well as the SpelExpressionParser class. It also removes the code block that creates an instance of SpelExpressionParser, parses an expression, and evaluates it. Instead, the expression is now treated as a plain string.Security enhancements for object deserialization and cookie handling
The diff introduces a new class, LookAheadObjectInputStream, which extends ObjectInputStream. This class overrides the resolveClass method to only allow deserialization of AuthToken objects, preventing potential deserialization attacks. The diff also modifies the way cookies are handled. Instead of directly adding a new cookie to the response, it now creates a Cookie object, sets it to HttpOnly and Secure, and then adds it to the response. This prevents potential cross-site scripting (XSS) and man-in-the-middle (MITM) attacks.