Don't inject the buildroot into the uv venv path.#23451
Closed
benjyw wants to merge 1 commit into
Closed
Conversation
benjyw
added
the
release-notes:not-required
This defeats remote caching on ephemeral runners where the buildroot path can change between runs. Instead we inject the fingerprint of the entire input digest, so we will get a new venv location whenever the lockfile (or uv version) changes. This seems like a good tradeoff, since uv venv creation is fast even in the pessimistic case.
tdyas
approved these changes
Jun 29, 2026
benjyw
marked this pull request as draft
July 1, 2026 02:46
Contributor
Author
|
I'm of two minds about this one, but first I want to give the reporter of #23438 a chance to see if it fixes this in their setup. |
Contributor
Author
|
Closing until we find harder evidence that it helps in real-world situations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This defeats remote caching on ephemeral runners
where the buildroot path can change between runs.
Instead we inject the fingerprint of the entire
input digest, so we will get a new venv location
whenever the lockfile (or uv version) changes.
This seems like a good tradeoff, since uv venv
creation is fast even in the pessimistic case.