Opt out of dataclass mapping when a model defines __table__#1406
Closed
mreid-tt wants to merge 3 commits intopallets-eco:mainfrom
mreid-tt:fix/dataclass-explicit-table
Closed
Opt out of dataclass mapping when a model defines __table__#1406mreid-tt wants to merge 3 commits intopallets-eco:mainfrom mreid-tt:fix/dataclass-explicit-table
mreid-tt wants to merge 3 commits intopallets-eco:mainfrom
mreid-tt:fix/dataclass-explicit-table
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mapped-as-dataclass is enabled under SQLAlchemy 2.x, models that
declare a pre-existing table cannot undergo the dataclass transform,
and SQLAlchemy raises:
InvalidRequestError: ORM Annotated Dataclasses do not support a pre-existing 'table' element
This PR opts out of the dataclass transform for such models by setting
sa_dataclass = False early in init_subclass. This preserves the
global mapped-as-dataclass behavior while restoring compatibility for
explicit-table mappings.
This fixes the failures in tests/test_model_bind.py::test_explicit_table
under the dataclass-enabled matrix.