Use SQLALCHEMY_ENGINE_OPTIONS as default engine options#1397
Closed
ZongXR wants to merge 2 commits intopallets-eco:mainfrom
ZongXR:set-SQLALCHEMY_BINDS-default-engine-options
Closed
Use SQLALCHEMY_ENGINE_OPTIONS as default engine options#1397ZongXR wants to merge 2 commits intopallets-eco:mainfrom ZongXR:set-SQLALCHEMY_BINDS-default-engine-options
ZongXR wants to merge 2 commits intopallets-eco:mainfrom
ZongXR:set-SQLALCHEMY_BINDS-default-engine-options
Conversation
use SQLALCHEMY_ENGINE_OPTIONS as default if engine options is not specified in SQLALCHEMY_BINDS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use SQLALCHEMY_ENGINE_OPTIONS as default engine options if engine options is not specified in SQLALCHEMY_BINDS
When engine options is not specified in
SQLALCHEMY_BINDS, this engine will lack options with the bind. Which may cause some unexpected errors such as database disconnect error.SQLALCHEMY_BINDS = {"main": "mysql+pymysql://root:root@localhost:3306/dbname"} SQLALCHEMY_ENGINE_OPTIONS = {"pool_pre_ping": True}For example, if someone use Flask-SQLalchemy like this, he will think
SQLALCHEMY_ENGINE_OPTIONSwill make effect inSQLALCHEMY_BINDS. But that's not the case.This PR use
SQLALCHEMY_ENGINE_OPTIONSas default engine options specifically when engine options is not specified inSQLALCHEMY_BINDS. So the code above will be same asSQLALCHEMY_BINDS = { "main": { "url": "mysql+pymysql://root:root@localhost:3306/dbname", "pool_pre_ping": True } }fixes #1396