Honor ADDITIONAL_EXCLUDED_DIRECTORIES in changed-files mode#8362
Merged
nvuillam merged 2 commits intoJul 18, 2026
Merged
Conversation
trevor-vaughan
force-pushed
the
fix/8360-additional-excluded-directories
branch
from
July 9, 2026 21:19
145dcf7 to
ca1c6ca
Compare
trevor-vaughan
marked this pull request as ready for review
July 9, 2026 21:38
trevor-vaughan
requested review from
Kurt-von-Laven,
bdovaz,
echoix and
nvuillam
as code owners
July 9, 2026 21:38
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
In changed-files mode (VALIDATE_ALL_CODEBASE: false), the file list was built straight from `git diff --name-only` without consulting the excluded directories, so files under EXCLUDED_DIRECTORIES / ADDITIONAL_EXCLUDED_ DIRECTORIES were still linted. Full-codebase mode prunes them during the os.walk traversal, creating inconsistent behavior between the two paths. Prune diff files whose ancestor directory is excluded so both modes behave identically. The matching rule (a directory matches by its basename at any nesting level, or by its workspace-relative path) is consolidated into a single `_is_excluded_dir()` predicate reused by both the git-diff pruning and the full-codebase os.walk traversal, so the two modes cannot drift. Closes oxsecurity#8360 Assisted-by: Claude Opus 4.8
trevor-vaughan
force-pushed
the
fix/8360-additional-excluded-directories
branch
from
July 14, 2026 15:29
ca1c6ca to
7cec321
Compare
nvuillam
approved these changes
Jul 14, 2026
nvuillam
left a comment
nvuillam
left a comment
Member
There was a problem hiding this comment.
Good catch, thanks for the PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In changed-files mode (VALIDATE_ALL_CODEBASE: false), the file list was
built straight from
git diff --name-onlywithout consulting the excludeddirectories, so files under EXCLUDED_DIRECTORIES / ADDITIONAL_EXCLUDED_
DIRECTORIES were still linted. Full-codebase mode prunes them during the
os.walk traversal, creating inconsistent behavior between the two paths.
Prune diff files whose ancestor directory is excluded so both modes behave
identically. The matching rule (a directory matches by its basename at any
nesting level, or by its workspace-relative path) is consolidated into a
single
_is_excluded_dir()predicate reused by both the git-diff pruningand the full-codebase os.walk traversal, so the two modes cannot drift.
Closes #8360
Assisted-by: Claude Opus 4.8