minor: add missing doc comments on Probe and SamlIdentityProvider#10351
Merged
david-crespo merged 1 commit intomainfrom May 1, 2026
Merged
minor: add missing doc comments on Probe and SamlIdentityProvider#10351david-crespo merged 1 commit intomainfrom
david-crespo merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fact that these structs were missing doc comments caused them to inherit the description of the identity metadata as their own description in the OpenAPI schema. I checked for other cases of this problem and didn't find any. I had this in my to-do list for a while, just knocking it out.