sync_switch_configuration: Don't allow dueling Nexuses based on a stale blueprint#10336
Open
jgallagher wants to merge 7 commits intojohn/bp-external-networking-genfrom
Open
sync_switch_configuration: Don't allow dueling Nexuses based on a stale blueprint#10336jgallagher wants to merge 7 commits intojohn/bp-external-networking-genfrom
sync_switch_configuration: Don't allow dueling Nexuses based on a stale blueprint#10336jgallagher wants to merge 7 commits intojohn/bp-external-networking-genfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit has two primary changes:
SystemNetworkingConfigtype to have an extra generation number inside it attached to the service NAT entries. This is a copy of the blueprint'sexternal_networking_generationnumber from the blueprint where the NAT entries were extracted. (This requires bumping the sled-agent API and all the extra machinery for changing the bootstore type; this is a little noisy but very mechanical.)sync_switch_configurationbg task to inspect this generation number and skip updating the bootstore if its currently-loaded blueprint has an olderexternal_networking_generation(i.e., is stale).Fixes #10320. Staged on top of #10331.