perf(react_compiler): de-monomorphize block rebuilding#24788
Draft
Boshen wants to merge 1 commit into
Draft
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the reactive transform block-rebuilding slow path so it is emitted once instead of once per transform implementation. The in-place fast path remains statically dispatched.
This reduces the arm64 macOS release example's
__textby 8,128 bytes and its gzip size by 2,896 bytes.Checks:
cargo test -p oxc_react_compiler;just readycompleted lint and check, with one unrelated parallel Oxlint suppression test failing transiently and passing in isolation.AI assistance was used for implementation and measurement.