Fix Async logging - #1059
Merged
Merged
Conversation
Remove check for auditing enabled before executing Auditor.
willpower232
approved these changes
Jun 20, 2026
willpower232
left a comment
willpower232
left a comment
Contributor
There was a problem hiding this comment.
I'm far away from a computer for a bit but makes sense from what I can see on my phone 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove check for auditing enabled before executing Auditor.
If the event has already been dispatched, it means that all audit requirements were met;
there is no need to check again.
Same as RecordCustomAudit :
laravel-auditing/src/Listeners/RecordCustomAudit.php
Lines 8 to 14 in 4fb70d2
It works in sync, but we don't take into account async queues.
@willpower232 hi, any comments?