Show deprecations on phpunit

[erikn69]

@willpower232 I thought about failOnDeprecation, but that would imply that the vendor's deprecation would also cause fails. Example: Laravel 11 with PHP 8.5 tests

But at least we can display deprecations messages to decide how to proceed

What do you think about it?

[willpower232]

This is what I mean, those extra settings don't seem to detect the deprecated code unless I'm looking at code which isn't covered by tests 😅

I also don't know what you mean about deprecations for PHP 8.5 + laravel 11, that also passes tests without any warnings 😅

[erikn69]

I'm looking at code which isn't covered by tests 😅

Because you're using PHP 8.4; if you were using PHP 8.5 you would see it.

I also don't know what you mean about deprecations for PHP 8.5 + laravel 11, that also passes tests without any warnings

With these configurations, it did show me the Laravel 11 warnings, but you should run the tests in PHP 8.5.

https://github.com/erikn69/laravel-auditing/actions/runs/23449357439/job/68221914863

1) /laravel-auditing/vendor/orchestra/testbench-core/laravel/config/database.php:61
Constant PDO::MYSQL_ATTR_SSL_CA is deprecated since 8.5, use Pdo\Mysql::ATTR_SSL_CA instead

---

And Laravel 11 reached its end of life before PHP 8.5 testing Laravel 11.x test
https://laravel.com/docs/13.x/releases

[willpower232]

You'll see the functions have a line through in my screenshot indicating they are deprecated but that is weird as I'm not running PHP 8.5 locally. Thanks vscode I guess 😅

Its also interesting that https://github.com/erikn69/laravel-auditing/actions/runs/23449357439/job/68221914863 is running phpunit 12 but thats not in composer.json 🤔

Either way, I'll take the github actions fail over whatever garbage my computer is doing 🙏

[erikn69]

is running phpunit 12 but thats not in composer.json

laravel-auditing/composer.json

Line 51 in c4a15ab

"phpunit/phpunit": "^11.0|^12.5.12"

[willpower232]

oh of course I was using an older version for those deprecated functions 🤦