fix: end composition only when toggling ascii_mode#2002
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts Trime’s Mode_switch behavior so that switching runtime options no longer always ends an active composition, aligning the IME behavior with the reported issue (#1514) while preserving the existing “keyboard switching commits” behavior.
Changes:
- Stop committing composition for every
Mode_switchoption toggle from the keyboard action listener. - Add special-case handling for
ascii_modeoption updates: when enablingascii_modeduring composition, commit raw input and clear composition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/src/main/java/com/osfans/trime/ime/keyboard/CommonKeyboardActionListener.kt | Removes unconditional commitComposition() after toggling a runtime option. |
| app/src/main/java/com/osfans/trime/core/Rime.kt | Adds ascii_mode-specific logic to commit raw input + clear composition on enable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
The commit message with |
before: switching any option in Mode_Switch would end composition and commit the first candidate after: only toggling ascii_mode ends composition and commits the raw input; switching other options no longer end composition. Keyboard switching still commits the first candidate
Bambooin
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before: switching any option in Mode_Switch would end composition and commit the first candidate
after: only toggling ascii_mode ends composition and commits the raw input; switching other options no longer end composition. Keyboard switching still commits the first candidate
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes #1514
Fixes #
Feature
Describe features of this pull request
Code of conduct
Code style
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info