Skip to content

fix: Proof request screen#1825

Merged
bryce-mcmath merged 3 commits intoopenwallet-foundation:mainfrom
MosCD3:moscd3-fix-proof-context
May 1, 2026
Merged

fix: Proof request screen#1825
bryce-mcmath merged 3 commits intoopenwallet-foundation:mainfrom
MosCD3:moscd3-fix-proof-context

Conversation

@MosCD3
Copy link
Copy Markdown
Contributor

@MosCD3 MosCD3 commented Apr 28, 2026

Summary of Changes

  • Add missing attribute mapping to OpenID mappers
  • Fix Proof presentation screen

Testing Instructions

Replace this text with detailed instructions on how to test the changes included in this PR.

Acceptance Criteria

Replace this text with the acceptance criteria that must be met for this PR to be approved.

Screenshots, videos, or gifs

Replace this text with embedded media for UI changes if they are included in this PR. If there are none, simply enter N/A

Breaking change guide

Replace this text with any breaking changes included in this PR along with how to address them in downstream projects. If there are none, simply enter N/A

Related Issues

Replace this text with issue #'s that are relevant to this PR. If there are none, simply enter N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • If applicable, added changeset(s)
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 28, 2026

🦋 Changeset detected

Latest commit: da5fb4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@bifold/core Patch
@bifold/remote-logs Patch
@bifold/oca Patch
@bifold/react-hooks Patch
@bifold/react-native-attestation Patch
@bifold/verifier Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MosCD3 MosCD3 marked this pull request as ready for review April 28, 2026 15:13
@MosCD3 MosCD3 requested a review from a team as a code owner April 28, 2026 15:13
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 43.47826% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.50%. Comparing base (25146c1) to head (da5fb4a).

Files with missing lines Patch % Lines
...Presentation/components/OpenIDProofRequestBody.tsx 0.00% 10 Missing ⚠️
...esentation/components/OpenIDProofRequestFooter.tsx 0.00% 10 Missing ⚠️
...esentation/components/OpenIDProofRequestHeader.tsx 0.00% 4 Missing ⚠️
packages/core/src/wallet/map-to-card.ts 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
+ Coverage   59.21%   59.50%   +0.29%     
==========================================
  Files         326      326              
  Lines       11280    11293      +13     
  Branches     3031     3134     +103     
==========================================
+ Hits         6679     6720      +41     
+ Misses       4572     4525      -47     
- Partials       29       48      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

MosCD3 added 3 commits May 1, 2026 15:03
Signed-off-by: Mostafa Gamal <moscd3@gmail.com>
Signed-off-by: Mostafa Gamal <moscd3@gmail.com>
Signed-off-by: Mostafa Gamal <moscd3@gmail.com>
@bryce-mcmath bryce-mcmath force-pushed the moscd3-fix-proof-context branch from c78a8c4 to da5fb4a Compare May 1, 2026 22:03
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 1, 2026

@bryce-mcmath bryce-mcmath merged commit c7b866a into openwallet-foundation:main May 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants