Implement password complexity enforcement#837
Closed
MohidSheraz wants to merge 2 commits into
Closed
Conversation
MohidSheraz
force-pushed
the
pci-401-password-complexity
branch
6 times, most recently
from
c797f2c to
350aa7a
Compare
gtema
force-pushed
the
pci-401-password-complexity
branch
from
350aa7a to
7c00578
Compare
gtema
requested changes
Jun 25, 2026
gtema
left a comment
gtema
left a comment
Collaborator
There was a problem hiding this comment.
you should always take care of synchronizing you fork repository with the origin. When you start working on the issue and create a branch ensure it is branched from the main branch and not from another branch (once you pushed the PR it again contained another commit for the test you have added in another PR). When you create PR or push a new revision do yourself a sanity check just looking at the commits tab whether everything is right
| "password is expired" | ||
| ); | ||
| } | ||
| #[tokio::test] |
Collaborator
There was a problem hiding this comment.
please add an empty line above to keep it separated from previous test
Signed-off-by: Mohid Sheraz <msheraz@andrew.cmu.edu>
MohidSheraz
force-pushed
the
pci-401-password-complexity
branch
from
7c00578 to
7e81fac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #401
This completes the SQL identity enforcement path for PCI-DSS 8.2.3 password complexity.
The config layer already supported
password_regex,password_regex_description, regex compilation, andvalidate_password(). This change calls password validation before password history checks, hashing, expiry calculation, and password storage.Tested with: