test: Add identity provider integration tests#831
Open
mashawes wants to merge 2 commits into
Open
Conversation
gtema
requested changes
Jun 23, 2026
gtema
left a comment
Collaborator
There was a problem hiding this comment.
generally good, but we need some refinements:
- add update tests as well
- try to add some negative tests (adding user to non-existing group or vice versa, using duplicate names, invalid data, delete not existing resource, etc)
| let domain = create_domain!(state)?; | ||
| let name = Uuid::new_v4().to_string(); | ||
|
|
||
| let group = state |
Collaborator
There was a problem hiding this comment.
let's please use "create_user!", "create_group!" like the tests/integration/src/identity/user_group/add.rs - we should be using this pattern more since it includes automatic cleanup of the resources created by the test what helps to fix test reliability. It is actually already present in some of the added tests.
| use tracing_test::traced_test; | ||
| use uuid::Uuid; | ||
|
|
||
| use openstack_keystone::identity::IdentityApi; |
Collaborator
There was a problem hiding this comment.
From now on this import is not necessary. Please remove it, but you actually should just run cargo check -p test_integration --tests to see warnings. Focus only in the files you add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds integration test coverage for the identity provider, following the existing test patterns and harness.
Closes #449
Note: this contribution was developed with AI assistance.