SPLAT-2796: Created vSphere GA and TP presubmits for API repo

[vr4manta]

SPLAT-2796

Changes

• Create new vSphere GA and TP presubmits for the API repo

Notes

The intent here was to only have GA and TP vSphere pre-submits fire when changes are made to modules most likely to affect vSphere. No need to always run a vSphere job on changes, unless we need to. User can still manually run this job if they think it should be tested.

Summary by CodeRabbit

This pull request adds CI infrastructure for vSphere testing of the OpenShift API repository. Two new e2e pipeline jobs have been added to the OpenShift API master branch CI configuration:

Changes Made:

• e2e-vsphere-ovn: GA (general availability) vSphere end-to-end test job
• e2e-vsphere-ovn-techpreview: Tech preview variant of the vSphere e2e test job

Configuration Details:
Both jobs are conditionally triggered via an updated regex pattern (pipeline_run_if_changed) that targets vSphere-relevant changes:

• vSphere-related Go type generation
• Feature-gated vSphere CustomResourceDefinition (CRD) manifests
• Specific CRD YAML files that would impact vSphere

Both jobs execute the openshift-e2e-vsphere-ovn workflow using the vsphere-elastic cluster profile. The tech preview variant additionally enables tech preview features by setting the FEATURE_SET: TechPreviewNoUpgrade environment variable.

Impact:
This configuration prevents always-on vSphere presubmits from running on every API repository change. Instead, vSphere tests run only when changes likely affect vSphere-specific code paths, reducing unnecessary CI execution while allowing developers to manually trigger vSphere presubmits for other changes if needed.

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2796 which is a valid jira issue.

Details

In response to this:

SPLAT-2796

Changes

• Create new vSphere GA and TP presubmits for the API repo

Notes

The intent here was to only have GA and TP vSphere pre-submits fire when changes are made to modules most likely to affect vSphere. No need to always run a vSphere job on changes, unless we need to. User can still manually run this job if they think it should be tested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

This PR adds two new e2e pipeline jobs to the OpenShift API CI configuration: e2e-vsphere-ovn and e2e-vsphere-ovn-techpreview. Both jobs are conditionally triggered by vSphere-related code changes and execute the openshift-e2e-vsphere-ovn workflow using the vsphere-elastic cluster profile. The techpreview variant additionally enables the TechPreviewNoUpgrade feature set.

Changes

vSphere e2e Pipeline Configuration

Layer / File(s)	Summary
New vSphere e2e pipeline jobs ci-operator/config/openshift/api/openshift-api-master.yaml	Added e2e-vsphere-ovn and e2e-vsphere-ovn-techpreview job definitions with pipeline_run_if_changed patterns covering vSphere type generation and CRD manifests. Both jobs run the openshift-e2e-vsphere-ovn workflow with the vsphere-elastic cluster profile; the techpreview variant sets FEATURE_SET: TechPreviewNoUpgrade.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding vSphere GA and TP (TechPreview) presubmit jobs to the API repository configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo-style tests found: repo contains zero onsi/ginkgo imports and no It/Describe/Context/When patterns in .go/.yaml. PR only adds static vSphere presubmit job config.
Test Structure And Quality	✅ Passed	PR only updates ci-operator YAML; no Ginkgo (_test.go) files with ginkgo/Describe/It patterns were changed in the commit.
Microshift Test Compatibility	✅ Passed	PR only adds/updates ci-operator YAML to create vSphere e2e jobs (e2e-vsphere-ovn, e2e-vsphere-ovn-techpreview); no new Ginkgo e2e test code is introduced.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR #80438 only changes ci-operator YAML (adds vSphere e2e presubmits) and no *_test.go/Ginkgo tests were added, so no SNO multi-node assumptions to flag.
Topology-Aware Scheduling Compatibility	✅ Passed	PR #80438 only adds CI e2e/presubmit jobs (e2e-vsphere-ovn and techpreview) with pipeline_run_if_changed; the diff contains no scheduling/affinity/topology-spread constraints.
Ote Binary Stdout Contract	✅ Passed	PR #80438 changes only ci-operator YAML to add vSphere e2e presubmit jobs; no OTE/openshift-tests Go code or stdout-writing setup is modified.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies CI configuration YAML, not Ginkgo test code. Custom check targets new test code additions, which are not present here.
No-Weak-Crypto	✅ Passed	Reviewed PR #80438 file diff for the added vSphere presubmit jobs; no occurrences of MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, or constant-time secret comparisons found.
Container-Privileges	✅ Passed	In PR #80438, the only changed YAMLs (openshift-api-master.yaml and openshift-api-master-presubmits.yaml) contain no matches for privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscal...
No-Sensitive-Data-In-Logs	✅ Passed	PR adds two CI YAML jobs with pipeline_run_if_changed regex and secret-file paths, but contains no password/token/API key/PII values and no echo/logging commands in the changes.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@vr4manta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-api-master-e2e-vsphere-ovn	openshift/api	presubmit	Presubmit changed
pull-ci-openshift-api-master-e2e-vsphere-ovn-techpreview	openshift/api	presubmit	Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[vr4manta]

/pj-rehearse pull-ci-openshift-api-master-e2e-vsphere-ovn-techpreview pull-ci-openshift-api-master-e2e-vsphere-ovn

[openshift-merge-bot]

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[jcpowermac]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac, vr4manta
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/api/OWNERS
• ci-operator/jobs/openshift/api/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vr4manta]

/retest

[vr4manta]

pj-rehearse failed due to origin issue. They all hit the

[sig-ci] [Early] prow job name should match os version [Suite:openshift/conformance/parallel]

which should now be fixed via openshift/origin#31287. Rerunning presubmits.

[vr4manta]

/pj-rehearse pull-ci-openshift-api-master-e2e-vsphere-ovn-techpreview pull-ci-openshift-api-master-e2e-vsphere-ovn

[openshift-merge-bot]

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[vr4manta]

/pj-rehearse ack

[openshift-merge-bot]

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.