Skip to content
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pkg/testsuites/standard_suites.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,17 @@ func AllTestSuites(ctx context.Context) ([]*ginkgo.TestSuite, error) {

// staticSuites are all known test suites this binary should run
var staticSuites = []ginkgo.TestSuite{
{
Name: "openshift/stable",
Description: templates.LongDesc(`
Umbrella suite for component suites that run under stable cluster conditions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stable suite here really means all tests in this suite are stable and highly reliable. Of course, the cluster is also stable.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes , I will add for it to not have any flaky tests as well.

`),
Qualifiers: []string{
"name.contains('[Feature:Builds]')",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intent to use qualifiers for all tests in origin (vs having child suites)?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem I was facing is the way openshift/build suite was filtering , so it was having many more tests if I use parent/child way.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can use OTE labels. Then we need to use another way to label tests. One way is to use AI to add labels to all tests across all repos. Another way is to dynamically label tests based on certain criteria. Method one will not work for kube tests I think.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right , dynamically adding labels to tests based on data that they are actually stable would be ideal ( But without a test id that won't be easy as names keeps changing )

},
Parallelism: 30,
ClusterStabilityDuringTest: ginkgo.Stable,
},
{
Name: "openshift/conformance",
Description: templates.LongDesc(`
Expand Down