-
Notifications
You must be signed in to change notification settings - Fork 4.8k
POC - Adding stable suite to build tests #31390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,6 +107,17 @@ func AllTestSuites(ctx context.Context) ([]*ginkgo.TestSuite, error) { | |
|
|
||
| // staticSuites are all known test suites this binary should run | ||
| var staticSuites = []ginkgo.TestSuite{ | ||
| { | ||
| Name: "openshift/stable", | ||
| Description: templates.LongDesc(` | ||
| Umbrella suite for component suites that run under stable cluster conditions. | ||
| `), | ||
| Qualifiers: []string{ | ||
| "name.contains('[Feature:Builds]')", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you intent to use qualifiers for all tests in origin (vs having child suites)?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The problem I was facing is the way openshift/build suite was filtering , so it was having many more tests if I use parent/child way.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if we can use OTE labels. Then we need to use another way to label tests. One way is to use AI to add labels to all tests across all repos. Another way is to dynamically label tests based on certain criteria. Method one will not work for kube tests I think.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. right , dynamically adding labels to tests based on data that they are actually stable would be ideal ( But without a test id that won't be easy as names keeps changing ) |
||
| }, | ||
| Parallelism: 30, | ||
| ClusterStabilityDuringTest: ginkgo.Stable, | ||
| }, | ||
| { | ||
| Name: "openshift/conformance", | ||
| Description: templates.LongDesc(` | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stable suite here really means all tests in this suite are stable and highly reliable. Of course, the cluster is also stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes , I will add for it to not have any flaky tests as well.