Skip to content

OSDOCS-20001: Fix invalid componentName and empty egress in ExternalS…#113229

Open
sampadasawant-36 wants to merge 1 commit into
openshift:enterprise-4.20from
sampadasawant-36:osdocs-20001-fix-externalsecretsconfig-examples
Open

OSDOCS-20001: Fix invalid componentName and empty egress in ExternalS…#113229
sampadasawant-36 wants to merge 1 commit into
openshift:enterprise-4.20from
sampadasawant-36:osdocs-20001-fix-externalsecretsconfig-examples

Conversation

@sampadasawant-36

@sampadasawant-36 sampadasawant-36 commented Jun 12, 2026

Copy link
Copy Markdown

…ecretsConfig documentation

  • Replace invalid componentName: CoreController with the correct CRD enum value ExternalSecretsCoreController in the allow-all-traffic egress module.
  • Replace the null egress: (deny-all) with egress: - {} (allow all) in the allow-all-traffic module.
  • Replace egress: - {} (empty object) with an explicit port 443/TCP egress rule in the create-externalsecretsconfig module.

Resolves: OSDOCS-20001

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

…ecretsConfig documentation

- Replace invalid componentName: CoreController with the correct CRD
  enum value ExternalSecretsCoreController in the allow-all-traffic
  egress module.
- Replace the null egress: (deny-all) with egress: - {} (allow all)
  in the allow-all-traffic module.
- Replace egress: - {} (empty object) with an explicit port 443/TCP
  egress rule in the create-externalsecretsconfig module.

Resolves: OSDOCS-20001
Co-authored-by: Cursor <cursoragent@cursor.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown

@sampadasawant-36: This pull request references OSDOCS-20001 which is a valid jira issue.

Details

In response to this:

…ecretsConfig documentation

  • Replace invalid componentName: CoreController with the correct CRD enum value ExternalSecretsCoreController in the allow-all-traffic egress module.
  • Replace the null egress: (deny-all) with egress: - {} (allow all) in the allow-all-traffic module.
  • Replace egress: - {} (empty object) with an explicit port 443/TCP egress rule in the create-externalsecretsconfig module.

Resolves: OSDOCS-20001

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown

Hi @sampadasawant-36. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dpateriya

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 12, 2026
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown

@sampadasawant-36: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants