Skip to content

8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update#2804

Closed
rm-gh-8 wants to merge 3 commits intoopenjdk:masterfrom
rm-gh-8:JDK-8068378-V21
Closed

8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update#2804
rm-gh-8 wants to merge 3 commits intoopenjdk:masterfrom
rm-gh-8:JDK-8068378-V21

Conversation

@rm-gh-8
Copy link
Copy Markdown
Contributor

@rm-gh-8 rm-gh-8 commented Apr 1, 2026

Backporting JDK-8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update.

This PR updates the PrintDialogsTest.java test instructions for clarity and formatting, and removed it from ProblemList.txt.

For parity with Oracle JDK. Already backported to 25.

Ran related test on macos-aarch64:

~/github/jtreg/build/images/jtreg/bin/jtreg -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java

The updated instructions:

Screenshot 2026-04-01 at 12 33 12 PM

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8068378 needs maintainer approval

Issue

  • JDK-8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2804/head:pull/2804
$ git checkout pull/2804

Update a local copy of the PR:
$ git checkout pull/2804
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2804/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2804

View PR using the GUI difftool:
$ git pr show -t 2804

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2804.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 1, 2026

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into pr/2803 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6e2ab84154e7cc11a31026c588a7dc3ceb446cc2 8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update Apr 1, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 1, 2026
@rm-gh-8 rm-gh-8 marked this pull request as ready for review April 1, 2026 19:32
@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 1, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Apr 1, 2026

/approval request for backport of JDK-8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update.

This is a test fix.

For parity with Oracle JDK. Already backported to 25.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 1, 2026

@rm-gh-8
8068378: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Apr 1, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 1, 2026

Webrevs

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Apr 7, 2026
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/2803 to master April 7, 2026 14:01
@openjdk-notifier
Copy link
Copy Markdown

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8068378-V21
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Apr 7, 2026
@openjdk openjdk bot added clean Identical backport; no merge resolution required ready Pull request is ready to be integrated labels Apr 7, 2026
@rm-gh-8
Copy link
Copy Markdown
Contributor Author

rm-gh-8 commented Apr 13, 2026

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 13, 2026

Going to push as commit c756e26.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 13, 2026
@openjdk openjdk bot closed this Apr 13, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 13, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 13, 2026

@rm-gh-8 Pushed as commit c756e26.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant