8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update#2804
8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update#2804rm-gh-8 wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
@rm-gh-8 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport of JDK-8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update. This is a test fix. For parity with Oracle JDK. Already backported to 25. |
Webrevs
|
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8068378-V21
git fetch https://git.openjdk.org/jdk21u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
/integrate |
|
Going to push as commit c756e26.
Your commit was automatically rebased without conflicts. |
Backporting JDK-8068378: [TEST_BUG]The java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java instruction need to update.
This PR updates the PrintDialogsTest.java test instructions for clarity and formatting, and removed it from ProblemList.txt.
For parity with Oracle JDK. Already backported to 25.
Ran related test on macos-aarch64:
~/github/jtreg/build/images/jtreg/bin/jtreg -jdk build/macosx-aarch64-server-release/images/jdk -m test/jdk/java/awt/Modal/PrintDialogsTest/PrintDialogsTest.javaThe updated instructions:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2804/head:pull/2804$ git checkout pull/2804Update a local copy of the PR:
$ git checkout pull/2804$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2804/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2804View PR using the GUI difftool:
$ git pr show -t 2804Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2804.diff
Using Webrev
Link to Webrev Comment