Skip to content

8374343: Fix SIGSEGV when lib/modules is unreadable#2720

Open
bulasevich wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-bulasevich-48846744-master
Open

8374343: Fix SIGSEGV when lib/modules is unreadable#2720
bulasevich wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-bulasevich-48846744-master

Conversation

@bulasevich
Copy link
Copy Markdown

@bulasevich bulasevich commented Mar 24, 2026

This pull request contains a backport of commit 48846744 from the openjdk/jdk repository.

The simple change fixes SIGSEGV crash during startup if the runtime image (lib/modules) exists but is unreadable.


Progress

  • JDK-8374343 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374343: Fix SIGSEGV when lib/modules is unreadable (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2720/head:pull/2720
$ git checkout pull/2720

Update a local copy of the PR:
$ git checkout pull/2720
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2720

View PR using the GUI difftool:
$ git pr show -t 2720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2720.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 24, 2026

👋 Welcome back bulasevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 24, 2026

@bulasevich This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374343: Fix SIGSEGV when lib/modules is unreadable

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 48846744ca96ce3c6464a1a440b9e46119dfbb88 8374343: Fix SIGSEGV when lib/modules is unreadable Mar 24, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 24, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 24, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 24, 2026

⚠️ @bulasevich This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 24, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 24, 2026

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Mar 26, 2026
@GoeLin
Copy link
Copy Markdown
Member

GoeLin commented Mar 27, 2026

Hi @bulasevich
please first backport to 26 and 25.
I remove the labels in the meantime.

@openjdk openjdk bot removed the approval Requires approval; will be removed when approval is received label Mar 27, 2026
@bulasevich
Copy link
Copy Markdown
Author

/approval request This simple change fixes a specific startup crash. The backport is clean and small, with low risk.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 2, 2026

@bulasevich
8374343: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants