8381899: Assertions and crashes in aot/cds tests on Linux Alpine

[vnkozlov]

KVM virtualization limited x86 CPU features to very small set: cx8, cmov, fxsr, mmx, sse, sse2, sse3, ssse3, sse4.1, sse4.2, popcnt, tsc, clflush, hv

As result stub generator produce very small number of stubs/intrinsics which does not have relocations. AOT stubs caching does not expect such case and causing this issue.

The fix is to check for absence of relocations and skip their processing when storing and loading AOT stubs.

Tested locally with -XX:UseAVX=0 -XX:-UseAES -XX:-UseSHA -XX:-UseFMA -XX:-UseCLMUL -XX:-UseBMI1Instructions -XX:-UseBMI2Instructions flags combination which emulates failing case.

Testing: tier1-3,comp-stress

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8381899: Assertions and crashes in aot/cds tests on Linux Alpine (Bug - P4)

Reviewers

• Andrew Dinn (@adinn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30657/head:pull/30657
$ git checkout pull/30657

Update a local copy of the PR:
$ git checkout pull/30657
$ git pull https://git.openjdk.org/jdk.git pull/30657/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30657

View PR using the GUI difftool:
$ git pr show -t 30657

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30657.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8381899: Assertions and crashes in aot/cds tests on Linux Alpine

Reviewed-by: adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• ccbbef5: 8381654: Tokenizer warnings dropped when annotation processing is present
• d9c5c86: 8374943: TestDirectBufferStatisticsEvent failed with too few statistics events
• 8357de8: 8334868: Ensure CheckUninstallModalHook is called in WPageDialogPeer._show
• ... and 6 more: https://git.openjdk.org/jdk/compare/d68065e7474c07233cf1752c2a6efcaf9d35066d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vnkozlov The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[vnkozlov]

@MBaesken please test this fix.

[mlbridge]

Webrevs

• 00: Full (9bb19629)

[MBaesken]

With your patch, the issues previously observed in hotspot :tier1 are gone.

[adinn]

Looks good.

[vnkozlov]

Thank you @MBaesken for testing and @adinn for review.

[vnkozlov]

/template append

[openjdk]

@vnkozlov The pull request template has been appended to the pull request body

[vnkozlov]

/integrate

[openjdk]

Going to push as commit a3309eb.
Since your change was applied there have been 10 commits pushed to the master branch:

• 701d0cb: 8381969: os::physical_memory is still broken in 32-bit systems when running on 64-bit OSes
• ccbbef5: 8381654: Tokenizer warnings dropped when annotation processing is present
• d9c5c86: 8374943: TestDirectBufferStatisticsEvent failed with too few statistics events
• ... and 7 more: https://git.openjdk.org/jdk/compare/d68065e7474c07233cf1752c2a6efcaf9d35066d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vnkozlov Pushed as commit a3309eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.