8381208: Init cause with the caught runtime exception#30656
8381208: Init cause with the caught runtime exception#30656aivanov-jdk wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@aivanov-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
| try { | ||
| job.print(doc, attributes); | ||
| } catch (PrintException e) { | ||
| throw new PrinterException(e.toString()); |
There was a problem hiding this comment.
Should we update this block as well?
There was a problem hiding this comment.
It makes sense but under another bug id because this one is a regression of JDK-8268675.
I'd like not to mix the changes.
There was a problem hiding this comment.
Should we update this block as well?
I submitted JDK-8382024: Propagate PrintException wrapped in PrinterException.
3 participants
Set the cause of a
PrinterExceptionto theRuntimeExceptioncaught during printing, thus wrap any other exception that occurs during printer into aPrinterException.I updated the test to print to a file—there's no need to send a print job to a physical printer. (Otherwise, the test asked me to select a file for the PDF Printer that I had.)
Progress
Error
- [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30656/head:pull/30656$ git checkout pull/30656Update a local copy of the PR:
$ git checkout pull/30656$ git pull https://git.openjdk.org/jdk.git pull/30656/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30656View PR using the GUI difftool:
$ git pr show -t 30656Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30656.diff
Using Webrev
Link to Webrev Comment