8368091: Use JUnit Jupiter API in sun/net/ext, sun/net/www and sun/net/spi tests by mahendrachhipa · Pull Request #30645 · openjdk/jdk

mahendrachhipa · 2026-04-09T10:22:42Z

Following tests are refactored to use JUnit Jupiter API :
sun/net/ext/ExtendedSocketOptionsTest.java
sun/net/www/protocol/file/DirPermissionDenied.java
sun/net/www/protocol/jar/MultiReleaseJarURLConnection.java
sun/net/www/protocol/jrt/Basic.java
sun/net/www/protocol/http/TestTransparentNTLM.java
sun/net/www/protocol/http/HttpHeaderParserTest.java
sun/net/www/http/RequestMethodCheck/RequestMethodEquality.java
sun/net/www/http/KeepAliveStreamCleaner/java.base/sun/net/www/http/KeepAliveStreamCleanerTest.java
sun/net/www/http/KeepAliveStreamCleaner/KeepAliveStreamCleanerTestDriver.java
sun/net/www/MessageHeaderTest.java
sun/net/spi/DefaultProxySelectorTest.java

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8368091: Use JUnit Jupiter API in sun/net/ext, sun/net/www and sun/net/spi tests (Sub-task - P4)

Reviewers

Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30645/head:pull/30645
$ git checkout pull/30645

Update a local copy of the PR:
$ git checkout pull/30645
$ git pull https://git.openjdk.org/jdk.git pull/30645/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30645

View PR using the GUI difftool:
$ git pr show -t 30645

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30645.diff

Using Webrev

Link to Webrev Comment

…n/net/spi tests

bridgekeeper · 2026-04-09T10:23:42Z

👋 Welcome back mchhipa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-04-09T10:23:47Z

@mahendrachhipa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368091: Use JUnit Jupiter API in sun/net/ext, sun/net/www and sun/net/spi tests

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

dd76306: 8382048: JFR: RecordingFile::write doesn't truncate when overwriting
03b46a3: 8381767: Refactor various java/net/[URL/Http]/ TestNG tests to use JUnit
ac74e6f: 8382055: G1: Remove unused unused args in mark_evac_failure_object
... and 47 more: https://git.openjdk.org/jdk/compare/67f590d8ba580d5cebbd041a30fef85c13d21e3b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2026-04-09T10:24:36Z

@mahendrachhipa The following label will be automatically applied to this pull request:

net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2026-04-09T13:51:32Z

Webrevs

01: Full - Incremental (5ba74886)
00: Full (8e2a4b5e)

dfuch · 2026-04-09T14:24:59Z

        try {
            selector.select(null);
-            Assert.fail("select() was expected to fail for null URI");
+            fail("select() was expected to fail for null URI");


we could simplify and use assertThrows here, and in other places/files as well

dfuch · 2026-04-09T14:32:18Z

 public class HttpHeaderParserTest {
-    @DataProvider(name = "responses")
-    public Object[][] responses() {
+    public static Object[][] responses() {


Consider simplifying the method to use List.of and simply return List<String>

dfuch · 2026-04-09T14:38:13Z

        try {
            selector.select(uri);
-            Assert.fail("select() was expected to fail for URI " + uri);
+            fail("select() was expected to fail for URI " + uri);


Same here. Use assertThrows, even consider removind this method.

Marcono1234

Hopefully these comments are useful, if not please let me know. They are only suggestions; feel free to ignore them, I am not an OpenJDK member.

Marcono1234 · 2026-04-10T12:45:43Z

Use JUnit's fail(...) instead of assertTrue(false, ...)?

Marcono1234 · 2026-04-10T12:55:19Z

Use assertNotNull?

Marcono1234 · 2026-04-10T12:55:37Z

Use assertNotEquals?

Marcono1234 · 2026-04-10T12:58:07Z

Not directly related to JUnit changes, but use canonical way to write array type here?

- String expected[] + String[] expected

dfuch

LGTM. Don't forget to log a new task for revisiting DirPermissionDenied.java.

mahendrachhipa · 2026-04-13T22:42:57Z

/integrate

openjdk · 2026-04-13T22:44:00Z

Going to push as commit 9d6a94e.
Since your change was applied there have been 54 commits pushed to the master branch:

531dad0: 8369917: LMS/HSS RFC 9858 Support
121165e: 8290892: C2: Intrinsify Reference.reachabilityFence
5cbc565: 8382081: AOT tests fail in add_stub_entries without JVMCI
... and 51 more: https://git.openjdk.org/jdk/compare/67f590d8ba580d5cebbd041a30fef85c13d21e3b...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-04-13T22:44:15Z

@mahendrachhipa Pushed as commit 9d6a94e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

JDK-8368091: Use JUnit Jupiter API in sun/net/ext, sun/net/www and su…

f615e23

…n/net/spi tests

openjdk bot changed the title ~~JDK-8368091: Use JUnit Jupiter API in sun/net/ext, sun/net/www and su…~~ 8368091: Use JUnit Jupiter API in sun/net/ext, sun/net/www and sun/net/spi tests Apr 9, 2026

openjdk bot added the net net-dev@openjdk.org label Apr 9, 2026

Removed trailing whitespace

8e2a4b5

openjdk bot added the rfr Pull request is ready for review label Apr 9, 2026

dfuch reviewed Apr 9, 2026

View reviewed changes

Marcono1234 reviewed Apr 10, 2026

View reviewed changes

Implemented the review comments.

5ba7488

openjdk bot added rfr Pull request is ready for review and removed rfr Pull request is ready for review labels Apr 10, 2026

dfuch approved these changes Apr 13, 2026

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Apr 13, 2026

openjdk bot added the integrated Pull request has been integrated label Apr 13, 2026

openjdk bot closed this Apr 13, 2026

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 13, 2026

Conversation

mahendrachhipa commented Apr 9, 2026 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Apr 9, 2026

Uh oh!

openjdk bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

dfuch Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dfuch Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dfuch Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Marcono1234 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Marcono1234 Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Marcono1234 Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Marcono1234 Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Marcono1234 Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

dfuch left a comment

Choose a reason for hiding this comment

Uh oh!

mahendrachhipa commented Apr 13, 2026

Uh oh!

openjdk bot commented Apr 13, 2026

Uh oh!

openjdk bot commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

mahendrachhipa commented Apr 9, 2026 •

edited by openjdk bot

Loading

openjdk bot commented Apr 9, 2026 •

edited

Loading

openjdk bot commented Apr 9, 2026 •

edited

Loading

mlbridge bot commented Apr 9, 2026 •

edited

Loading