refactor: Use formik and yup, and simplify hooks#2993
refactor: Use formik and yup, and simplify hooks#2993
Conversation
|
Thanks for the pull request, @xitij2000! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
This commit is mainly to get git to reconise the rename so file history is maintained.
146be13 to
ab0d327
Compare
| isOpen={isConfirmOpen} | ||
| close={() => { setConfirmOpen(false); }} | ||
| title={<FormattedMessage {...messages[`ConfirmSwitchMessageTitle-${editorType}`]} />} | ||
| title={intl.formatMessage(messages[`ConfirmSwitchMessageTitle-${editorType}`])} |
There was a problem hiding this comment.
Changed because title is only supposed to be a string and not a ReactNode.
ab0d327 to
488b887
Compare
This change converts the Image Editor Modal to typescript and simplifies the hooks switching to Formik + Yup for form validation. It updates the tests to check the behaviour of the component as a whole rather than testing small components.
488b887 to
ad087a0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2993 +/- ##
==========================================
+ Coverage 95.57% 95.62% +0.05%
==========================================
Files 1366 1378 +12
Lines 31507 32234 +727
Branches 6885 7120 +235
==========================================
+ Hits 30113 30824 +711
- Misses 1344 1361 +17
+ Partials 50 49 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This change converts the Image Editor Modal to TypeScript and simplifies the hooks switching to Formik + Yup for form validation.
It updates the tests to check the behaviour of the component as a whole rather than testing small components.
This lays the groundwork for the CSS editor work.
Supporting information
Testing instructions
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'