Skip to content

fix: django admin select2#4717

Closed
ambroiseRabier wants to merge 2 commits into
openedx:masterfrom
ambroiseRabier:fix-django-admin-select2
Closed

fix: django admin select2#4717
ambroiseRabier wants to merge 2 commits into
openedx:masterfrom
ambroiseRabier:fix-django-admin-select2

Conversation

@ambroiseRabier

@ambroiseRabier ambroiseRabier commented Apr 13, 2026

Copy link
Copy Markdown

This solves: https://discuss.openedx.org/t/how-to-create-a-programs-in-discovery/18666/2 (contains images describing the issue)

I don't have a ticket to link.

I have sent the form for the CLA.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 13, 2026
@openedx-webhooks

openedx-webhooks commented Apr 13, 2026

Copy link
Copy Markdown

Thanks for the pull request, @ambroiseRabier!

This repository is currently maintained by @openedx/2u-phoenix.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@iloveagent57

Copy link
Copy Markdown
Contributor

An alternative (very similar) proposed approach to this issue: #4718
But fundamentally, we have to drop DAL as a dependency, it's not django 5 compatible and appears unmaintained.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 16, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Roadmap Feature Tickets (Product) in Contributions Apr 16, 2026
@mphilbrick211 mphilbrick211 moved this from Roadmap Feature Tickets (Product) to Needs Tests Run or CLA Signed in Contributions Apr 16, 2026
@mphilbrick211

Copy link
Copy Markdown

Hi @ambroiseRabier! Welcome, and thank you for this contribution! In order for your CLA check to turn green, you'll need to submit a CLA form. If you are contributing as an individual, please fill out the individual CLA form here.

If you are contributing on behalf of an organization, please have your manager reach out to oscm@axim.org so you may be added to your org's existing entity agreement.

Please let me know if you have any questions. Thanks!

@e0d

e0d commented Apr 17, 2026

Copy link
Copy Markdown

@ambroiseRabier it looks like there are some test failures, can you have a look?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Apr 17, 2026
@ambroiseRabier

Copy link
Copy Markdown
Author

Well, I spent time fixing the tests, but it seems #4718 fixed the same issue 10 days ago.

@github-project-automation github-project-automation Bot moved this from Needs Tests Run or CLA Signed to Done in Contributions May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants