Skip to content

feat: add sandbox agents with clearer PTY Python validation#1221

Merged
seratch merged 2 commits intofeat/sandbox-agentsfrom
sandbox-pty-validation
May 2, 2026
Merged

feat: add sandbox agents with clearer PTY Python validation#1221
seratch merged 2 commits intofeat/sandbox-agentsfrom
sandbox-pty-validation

Conversation

@seratch
Copy link
Copy Markdown
Member

@seratch seratch commented May 2, 2026

This pull request adds the sandbox agents runtime and provider integrations, and improves the local Unix/Docker PTY path so tty: true fails early with a configuration error when the Python PTY bridge is unavailable.

The PTY bridge currently requires Python 3 because Node.js does not provide a standard-library API for allocating and driving a POSIX pseudo-terminal, while Python's standard library provides the needed pty, select, signal, os.execvpe, and waitpid primitives without adding a native addon or shipping a platform-specific helper binary. Alternatives such as node-pty or a small compiled helper remain possible future directions, but they add distribution, ABI, or prebuilt-binary complexity; for now the SDK keeps the Python bridge and makes the requirement explicit and diagnosable. The implementation checks the configured Python executable using the same PATH/environment used for the PTY bridge, caches successful checks, and reports that users can install python3 or set OPENAI_AGENTS_PYTHON.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 2, 2026

⚠️ No Changeset found

Latest commit: 58f339d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2b72e4511

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/agents-core/src/sandbox/sandboxes/shared/pty.ts
@seratch seratch merged commit e2a08ad into feat/sandbox-agents May 2, 2026
6 checks passed
@seratch seratch deleted the sandbox-pty-validation branch May 2, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant