fix: restore PTY child terminal signal defaults#1220
Merged
seratch merged 1 commit intofeat/sandbox-agentsfrom May 2, 2026
Merged
fix: restore PTY child terminal signal defaults#1220seratch merged 1 commit intofeat/sandbox-agentsfrom
seratch merged 1 commit intofeat/sandbox-agentsfrom
Conversation
|
seratch
added a commit
that referenced
this pull request
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes Unix-local PTY child signal handling so terminal-generated interrupts are not affected when the parent process is temporarily ignoring terminal signals. It restores
SIGINTandSIGQUITto their default dispositions before the PTY child process execs, and adds regression coverage for Ctrl-C and Ctrl-\ behavior under ignored parent signal handlers.see also: openai/openai-agents-python#3082