Skip to content

fix: restore PTY child terminal signal defaults#1220

Merged
seratch merged 1 commit intofeat/sandbox-agentsfrom
sandbox-agents-pty
May 2, 2026
Merged

fix: restore PTY child terminal signal defaults#1220
seratch merged 1 commit intofeat/sandbox-agentsfrom
sandbox-agents-pty

Conversation

@seratch
Copy link
Copy Markdown
Member

@seratch seratch commented May 2, 2026

This pull request fixes Unix-local PTY child signal handling so terminal-generated interrupts are not affected when the parent process is temporarily ignoring terminal signals. It restores SIGINT and SIGQUIT to their default dispositions before the PTY child process execs, and adds regression coverage for Ctrl-C and Ctrl-\ behavior under ignored parent signal handlers.

see also: openai/openai-agents-python#3082

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 2, 2026

⚠️ No Changeset found

Latest commit: fbf8f9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@seratch seratch merged commit a5495f9 into feat/sandbox-agents May 2, 2026
6 checks passed
@seratch seratch deleted the sandbox-agents-pty branch May 2, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant