Skip to content

feat(flagd-core): add disabled flag evaluation e2e scenarios#395

Draft
jonathannorris wants to merge 1 commit into
mainfrom
feat/disabled-evaluator-tests
Draft

feat(flagd-core): add disabled flag evaluation e2e scenarios#395
jonathannorris wants to merge 1 commit into
mainfrom
feat/disabled-evaluator-tests

Conversation

@jonathannorris
Copy link
Copy Markdown
Member

@jonathannorris jonathannorris commented May 25, 2026

Summary

  • Adds tests/e2e/features/disabled.feature with a scenario outline covering boolean, string, integer, float, and object disabled-flag evaluation
  • Adds tests/e2e/test_disabled.py with a local evaluator fixture loaded with disabled flag definitions and a scenarios() call against the feature file

Why no flagd_core.py changes

The analogous Java PR (open-feature/java-sdk-contrib#1800) needed a FlagdCore.java change because returning reason=DISABLED is new documented behavior (see ADR). Python's in-process evaluator already returns reason=DISABLED with the caller's code default since the evaluator was extracted in #377, so no implementation change is required here. This PR adds the BDD coverage to verify that behavior against all evaluation types.

Related Issues

Closes #393
Relates to: open-feature/flagd#1965

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test-harness subproject commit in providers/openfeature-provider-flagd/openfeature/test-harness to a newer version. There are no review comments, and I have no additional feedback to provide.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.23%. Comparing base (daafd73) to head (2006b8f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
- Coverage   96.20%   91.23%   -4.97%     
==========================================
  Files          47       17      -30     
  Lines        1741      468    -1273     
==========================================
- Hits         1675      427    -1248     
+ Misses         66       41      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
@jonathannorris jonathannorris force-pushed the feat/disabled-evaluator-tests branch from 72c282e to 2006b8f Compare May 25, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: flagd-core in-process evaluator returns reason=DISABLED for disabled flags

3 participants