feat(flagd-core): add disabled flag evaluation e2e scenarios#395
Draft
jonathannorris wants to merge 1 commit into
Draft
feat(flagd-core): add disabled flag evaluation e2e scenarios#395jonathannorris wants to merge 1 commit into
jonathannorris wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #395 +/- ##
==========================================
- Coverage 96.20% 91.23% -4.97%
==========================================
Files 47 17 -30
Lines 1741 468 -1273
==========================================
- Hits 1675 427 -1248
+ Misses 66 41 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
72c282e to
2006b8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/e2e/features/disabled.featurewith a scenario outline covering boolean, string, integer, float, and object disabled-flag evaluationtests/e2e/test_disabled.pywith a localevaluatorfixture loaded with disabled flag definitions and ascenarios()call against the feature fileWhy no
flagd_core.pychangesThe analogous Java PR (open-feature/java-sdk-contrib#1800) needed a
FlagdCore.javachange because returningreason=DISABLEDis new documented behavior (see ADR). Python's in-process evaluator already returnsreason=DISABLEDwith the caller's code default since the evaluator was extracted in #377, so no implementation change is required here. This PR adds the BDD coverage to verify that behavior against all evaluation types.Related Issues
Closes #393
Relates to: open-feature/flagd#1965