Simplifying config parameters - #356
Conversation
|
Within the scope of this PR is remove duplicated parameters that don't change from our project base config file |
|
Thank you @Mwiche96. Completely agree that our configs need tidying-up, and great to have an initial implementation sketch. I think it's essential that we'll also sketch some architecture concept. To my understanding, there are the following questions to address.
|
|
Proposals
Alternatively we can maintain the currently organisation of the configs which is already familiar with the team and which still works given the naming conventions we would adopt for the configs. @ekatef and @tacwebservices what do you think about this logic? |
|
Thank you @Mwiche96, the concept sounds well-elaborated and perfectly relevant to me. Adding also an insight we have obtained in our discussion for point four: having regional-specific configs placed grouped helps to avoid merge conflicts and facilitates maintenance. On that, I can also add the test configs may deserve some additional attention since they can create quite some issues when merging upstream. It would be good to have an opinion by @tacwebservices since it's a point which has high relevance for modelling runs. |
|
Hey @Mwiche96, as discussed the implementation looks consistent and well-structured. I have gone trough the changes with a more in-depth review and can confirm that they look perfectly relevant for our task. The only point I have noticed is gihtub being not great in showcasing this kind of changes. So, I'm adding here a list of improvements this PR brings in and some comments on them following-up our discussion.
Points 3 and 4 would have some implications for training since we'll need to remember to apply a dedicated config over our config structure to adjust parameters of a specific run with it's goal. But I think that the consistent structure of the configs will make things easier in any case. |
|
@ekatef thank you very much for the review. Yes on the retreival sections, I figured it was easier to have them sitting in one place as opposed to having them on a per config basis. |
If appropriate, go to the
Previewtab and select the appropriate sub-template:Otherwise, stick with the template below. And remove this text from the PR.
Closes #351
<--Fill in the number of the issue this PR address. This will automatically close the referenced issue
when this PR is merged -->
Changes proposed in this Pull Request
There are several parameters that are duplicated from the project base config which is the validation_dispatch_zambia.yaml and can be safely removed to aid in userbility. there is also an orphaned file
config.zm.default.yamlwhich is not utilised anywhere in the workflow that can be removed alsoChecklist
<--This checklist must be filled in. If the item is not applicable, tick anyway.-->
envs/environment.yamlanddoc/requirements.txt.config.default.yamlandconfig.tutorial.yaml.test/(note tests are changing the config.tutorial.yaml)doc/configtables/*.csvand line references are adjusted indoc/user-guide/configuration.mdanddoc/tutorials/electricity-model.md.doc/assets/scripts/extract_config_snippets.pyaccordingly.configs/bundle_config.yaml.doc/release-notes.mdis amended in the format of previous release notes, including reference to the requested PR.