Check CFBundleSupportedPlatforms before installing apps (and a minor spelling fix)#936
Open
forcequitOS wants to merge 4 commits into
Open
Check CFBundleSupportedPlatforms before installing apps (and a minor spelling fix)#936forcequitOS wants to merge 4 commits into
forcequitOS wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if the original behavior was technically intended or not, but I think my change makes sense to prevent users from attempting to install an app that's not at all compatible with iOS (like a tvOS app, watchOS app, etc.), as I just witnessed someone attempt to do this and figured I should try to correct it.
All I'm doing is cross referencing between TrollStore's own
CFBundleSupportedPlatformsarray and the new app'sCFBundleSupportedPlatformsarray and looking for a match. Hardcoding to look for iPhoneOS in the new app'sCFBundleSupportedPlatformsarray would also work sufficiently.I also fixed a minor spelling issue in the Settings view while I was at it.
Note:
My testing was done on TrollStore Lite, the CoreTrust bypass seemingly wasn't applying correctly when I was compiling it even though it did say "Applied CoreTrust Bypass!" on the signing stage, not sure if it's an issue on my side or not. Regular TrollStore was just crashing at launch on both devices I was testing on.