fix: write CA certs to XDG_RUNTIME_DIR for per-user isolation#22
Open
cfis wants to merge 1 commit into
Open
Conversation
ec821a5 to
b648163
Compare
Author
|
Rebased to current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeCaCertificateandbuildCombinedCaBundlewrite totmpdir()(/tmp/onecli-proxy-ca.pem,/tmp/onecli-combined-ca.pem), which is shared system-wide on Linux. Two users running OneCLI on one host clobber each other's cert files — last writer wins, the other user's containers trust the wrong CA.This switches both writers to
process.env.XDG_RUNTIME_DIR ?? tmpdir().XDG_RUNTIME_DIRis/run/user/<uid>/on Linux user sessions — already per-user, already cleaned up on logout. The fallback totmpdir()preserves existing behavior on macOS/Windows and on Linux without an XDG runtime dir set.