Skip to content

fix: add ",z" SELinux relabel to CA cert bind mounts #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cfis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add ",z" SELinux relabel to CA cert bind mounts #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/container/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,13 @@ export class ContainerClient {
args.push("-e", `${key}=${value}`);
}

// Write CA certificate to host temp file and mount into container
// Write CA certificate to host temp file and mount into container.
// `,z` is a shared SELinux relabel so the container can read the cert
// on enforcing systems (Fedora + podman). No-op on non-SELinux hosts.
const hostCaPath = writeCaCertificate(config.caCertificate);
args.push(
"-v",
`${hostCaPath}:${config.caCertificateContainerPath}:ro`,
`${hostCaPath}:${config.caCertificateContainerPath}:ro,z`,
);

// Build combined CA bundle for system-wide trust (curl, Python, Go, etc.)
Expand All @@ -147,7 +149,7 @@ export class ContainerClient {
args.push("-e", "SSL_CERT_FILE=/tmp/onecli-combined-ca.pem");
// DENO_CERT: Deno does not respect SSL_CERT_FILE, it has its own env var
args.push("-e", "DENO_CERT=/tmp/onecli-combined-ca.pem");
args.push("-v", `${combinedPath}:/tmp/onecli-combined-ca.pem:ro`);
args.push("-v", `${combinedPath}:/tmp/onecli-combined-ca.pem:ro,z`);
}
}

Expand Down