Open
Conversation
Since `.base10()` is similar to `toHex()`, we can use the same string to retrieve the number without modifying `lime`, which can lead to higher complexity in the tests as `colord` does not support numbers as input and would require an `if (typeof lime[format] === 'number') continue;` or an `if (format === 'base10') continue;` check otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104
I chose not to add
src/colorModels/base10.ts(and therefore support numbers as input) because it would be impossible to properly determine whether a number is RGB or RGBA, so the solution I reached was to just add a method.This addition would also prove very helpful for APIs that natively use (and support) base10 numbers, such as Discord.