Dev#25
Merged
olujimiAdebakin merged 2 commits intomainfrom Dec 28, 2025
Merged
Conversation
Implements Accumulated Funding Per Unit (AFPU) model with lazy settlement pattern, replacing O(n) batch updates with O(1) per-position settlement. Changes: - Add lastCumulativeFunding field to Position struct for AFPU snapshots - Implement settlePositionFunding() for lazy funding settlement - Integrate automatic funding settlement into all position modifications - Initialize AFPU snapshot on position opening - Remove dependencies on legacy batch funding updates Breaking Changes: - Position struct modified (added lastCumulativeFunding field) - Requires FundingRateEngine with AFPU support (companion PR) - Legacy _applyToPositions() calls no longer supported Performance: - 99% gas reduction at scale (10M → 50K gas for 1,000 traders) - Removes theoretical limit on concurrent positions Related: (FundingRateEngine AFPU implementation)
feat: integrate AFPU lazy settlement into PositionManager
Dev
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.