You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 26, 2025. It is now read-only.
This PR introduces a boolean argument to clocal_exp_editsim and clocal_exp_editsim_withbp that indicates whether you want to ignore the non-spiking columns during the edit similarity calculation.
See #23 for the details.
After updating deprecated numpy type (np.int changed to np.int_), Pytest passed with around 1000 warnings. Almost all of them are deprecation warnings related to gensimmat and generate_signature_matrix_cpu_single:
DeprecationWarning: NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of -8774792623331384397 to uint32 will fail in the future.
For the old behavior, usually:
np.array(value).astype(dtype)
will give the desired result (the cast overflows).
simmat_lsh = es.gensimmat(self.binmat, window, window, numband=1, bandwidth=50, minhash=True)
DeprecationWarning: NumPy will stop allowing conversion of out-of-bound Python integers to integer arrays. The conversion of 1364461791113035166 to uint32 will fail in the future.
For the old behavior, usually:
np.array(value).astype(dtype)
will give the desired result (the cast overflows).
sigmat = minhash.generate_signature_matrix_cpu_single(numhash, numband, bandwidth, self.b)
Which persist even after changing dtype=np.uint32 to .astype(uint32) in minhash.pyx. However, given the high value of the integers in the error messages, I wonder if there is a better way to type cast and/or operate them.
Older local version of spykesim still running on 3.7.3 but with similar modifications as introduced by this branch also passes the tests with 78 warnings.
Considering how Python 3.7 is now unsupported, I believe it would be good to confirm that this library can work on a more recent version by working on the necessary type modifications.
After pip installing pandas, nose and hdbscan, pytest passed with a single warning on Linux (pytest-7.4.4, pluggy-1.2.0):
DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
from imp import find_module, load_module, acquire_lock, release_lock
Deprecation warnings and issues related to newer versions of Python and numpy still need to be treated (probably by another pull request), but it seems that the modifications introduced here are working as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a boolean argument to
clocal_exp_editsimandclocal_exp_editsim_withbpthat indicates whether you want to ignore the non-spiking columns during the edit similarity calculation.See #23 for the details.