prov/efa: Fix the completion report for delivery complete#12115
Open
shijin-aws wants to merge 1 commit intoofiwg:mainfrom
Open
prov/efa: Fix the completion report for delivery complete#12115shijin-aws wants to merge 1 commit intoofiwg:mainfrom
shijin-aws wants to merge 1 commit intoofiwg:mainfrom
Conversation
Today, we report tx completions upon getting the receipt packet rx completion. This is wrong, because the tx completions may not arrive yet at this time and the buffer can still be used by the device. We cannot report completion in this case because the buffer cannot be safely reused by the application after getting the completion. This patch fixes this bug by making delivery complete protocols only report completions when it get all tx ops finished and receives the receipt pkts. Signed-off-by: Shi Jin <sjina@amazon.com>
shijin-aws
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, we report tx completions upon getting the receipt packet rx completion. This is wrong, because the tx completions may not arrive yet at this time and the buffer can still be used by the device. We cannot report completion in this case because the buffer cannot be safely reused by the application after getting the completion.
This patch fixes this bug by making delivery complete protocols only report completions when it get all tx ops finished and receives the receipt pkts.