New appliance support: Fridge, Hub, Hood - #141
Open
JanezKr wants to merge 16 commits into
Open
Conversation
JanezKr
commented
Jul 3, 2022
JanezKr
commented
- Different program options on Oven
- New appliances support:
- Fridge
- Hub
- Hood (experimental)
- Different program options on Oven
- New appliances support:
- Fridge
- Hub
- Hood (experimental)
bugfixes
new sensors
Author
|
Please Olivér, can you merge my code too. I add few new appliances in last months. Tanks in advance, Janez |
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
ofalvai
reviewed
Nov 19, 2022
Owner
|
Thank you @JanezKr for the contribution and apologies for the long delay from me. I had a quick look at the PR and added a few comments about the various new appliances and features, please take a look. A few general comments:
|
Some fixes on Fridge and Hood.
…er into carbon_filter_clean_needed renamed grease_filter into grease_filter_clean_needed and carbon_filter into carbon_filter_clean_needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.