fix(i18n): home welcome/noApps keys missing → English leak on zh home#1735
Merged
Conversation
…h English leak)
HomePage renders t('home.welcomeAdminDescription') (the admin empty-state
'build with AI' body), plus t('home.noAppsTitle') / t('home.noAppsDescription')
for non-admins — but none of those keys existed in any locale, so they fell
back to the English defaultValue. On the Chinese product surface that meant the
env home magic-moment body rendered in English under a Chinese title (mixed
language). Add the keys to en (source) + zh (translated). Other locales keep
falling back to the English defaultValue as before (no regression); full
coverage for the remaining 8 locales is a separate i18n pass.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HomePagerenderst('home.welcomeAdminDescription')(the admin empty-state "build with AI" body) andt('home.noAppsTitle')/t('home.noAppsDescription')(non-admin state) — but none of those keys existed in any locale, so they fell back to the EnglishdefaultValue. On the Chinese product surface the env-home magic-moment rendered an English body under a Chinese title (the mixed-language issue from the customer-journey audit).Fix
Add the three keys to
en(source) +zh(translated). The remaining 8 locales keep falling back to the EnglishdefaultValueexactly as before — no regression; full coverage for those is a separate i18n pass (the parity test only enforces top-level sections).Tests
@object-ui/i18nbuild clean; suite 113 pass.Ships to cloud via
bump-objectui.