feat: action modal transport with placement (SDUI #2)#1488
Merged
Conversation
useActionModal renders an action modal envelope in Dialog/Sheet/Drawer by placement (center/side/bottom/fullscreen), rendering arbitrary SchemaNode content via SchemaRenderer. Wired onModal into RecordDetailView and removed 'modal' from the handler registry so type:'modal' reaches the client handler (registered handlers shadow the built-in executeModal). Unit tests + dev route /dev/modal verifying all four placements. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
❌ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a unified action modal transport so
type:'modal'actions open client-side in the right container, rendering arbitrary SchemaNode content.useActionModal(app-shell): oneonModalhandler → Dialog (center/fullscreen), Sheet (side), or Drawer (bottom), sized sm|default|lg|xl.contentis any SchemaNode rendered viaSchemaRenderer; string targets /{objectName,mode}still open aModalForm.onModalintoRecordDetailViewand removedmodalfrom the handler registry (registered handlers shadow the built-inexecuteModal), so modal actions stop being routed to a server POST.Verification
/dev/modal(center/side/bottom/fullscreen).Follow-up: optional refactor of DashboardView's open-coded modal handler onto this hook.
🤖 Generated with Claude Code