feat: ADR-0047 implementation (framework) — userFilters spec, reference diagnostics, showcase examples, authoring form#1792
Merged
Conversation
…list, view reference diagnostics - UserFilterFieldSchema/UserFiltersSchema in ui/view.zod.ts, attached as ListViewSchema.userFilters (blesses the shape objectui already renders) - 'chart' added to VisualizationTypeSchema (8-type parity with ListView.type); appearance.allowedVisualizations remains the runtime whitelist - InterfacePageConfig: userFilters now uses the real UserFiltersSchema (replaces the misplaced elements visualization enum, zero prior usage); new sourceView for the ADR-0047 iron rule (pages reference views) - computeViewReferenceDiagnostics in objectql: cross-document checks Zod cannot express (userFilters/tabs fields exist on source object, kanban groupBy is select-like), merged into _diagnostics on view getMetaItem Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…amples + skill decision rules - showcase_task default view gains filter tabs, userFilters dropdowns (status/priority/done) and an allowedVisualizations whitelist — the few-shot corpus for AI authors was previously empty - new Task Workbench interface page: references the default view (sourceView), locked grid, author-curated dropdowns, filter:false — the canonical interface-mode example; nav entry added next to the data-mode Tasks entry - objectstack-ui skill: two-run-modes decision table, default-to-data-mode rule, the iron rule, and the userFilters/tabs/appearance authoring block Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…authoring form The Studio view inspector is spec-form-driven, so adding the section here renders the full authoring UI (userFilters fields/tabs repeaters with the element style selector, appearance.allowedVisualizations, userActions, addRecord, showRecordCount) with zero client code — verified in the browser against the showcase. Also registers TaskWorkbenchPage in the showcase stack config (the phase-3 nav entry referenced it). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jun 13, 2026
feat: ADR-0047 account workbench — interface page + quick-filter dropdowns
objectstack-ai/hotcrm#383
Merged
xuyushun441-sys
added a commit
that referenced
this pull request
Jun 13, 2026
…1801) Adds the 'Interface (list pages)' section to the Studio page form, visible when type == 'list': the interfaceConfig composite renders the full Airtable-right-panel equivalent — Source/Source View (iron-rule help text), Levels, Filter By rows, Appearance (Show Description + Allowed Visualizations tags), User Filters (Element style + Fields rows with showCount) and User Actions toggles. Completes the phase-5 authoring surface: views got their End-user controls section in #1792; pages now have the same for interface mode. Browser-verified in Studio against the showcase Task Workbench page. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the framework side of ADR-0047 (phases 1, 3, 5).
Phase 1 — spec + diagnostics
UserFilterFieldSchema/UserFiltersSchemainui/view.zod.ts, attached asListViewSchema.userFilters— formalizes the shape the objectui client already renders'chart'added toVisualizationTypeSchema(8-type parity);appearance.allowedVisualizationsconfirmed as the runtime visualization whitelistInterfacePageConfig:userFiltersnow uses the realUserFiltersSchema(replaces the misplacedelementsvisualization enum — zero prior usage); newsourceViewfor the iron rule (pages reference views, never restate them)computeViewReferenceDiagnostics(objectql): cross-document checks Zod cannot express — userFilters/tabs fields must exist on the source object, kanban groupBy must be select-like — merged into_diagnosticson viewgetMetaItem. Unit-tested + verified live (bad field →reference_not_found, date groupBy →invalid_binding)Phase 3 — examples + AI authoring rules
showcase_taskdefault view: filtertabs,userFiltersdropdowns,allowedVisualizationswhitelist (the few-shot corpus was empty)interfaceConfig) + nav entry — the canonical interface-mode exampleobjectstack-uiskill: two-run-modes decision table, default-to-data-mode rule, the iron rulePhase 5 — authoring form
viewFormgains an End-user controls section; the spec-form-driven Studio inspector renders the full userFilters/tabs/appearance authoring UI with zero client codeVerification
All behavior verified live in the browser against
examples/app-showcase+ the objectui console (companion PR in objectui): data-mode tabs/dropdowns/visualization switcher, interface-mode curated page, reference diagnostics, Studio authoring panel.🤖 Generated with Claude Code