Skip to content

Modernize project: Upgrade Scala/Play/sbt, add CI, and migrate code#29

Open
Ayomide-R wants to merge 3 commits intonymanjens:masterfrom
Ayomide-R:feature/upgrade-dependencies
Open

Modernize project: Upgrade Scala/Play/sbt, add CI, and migrate code#29
Ayomide-R wants to merge 3 commits intonymanjens:masterfrom
Ayomide-R:feature/upgrade-dependencies

Conversation

@Ayomide-R
Copy link
Copy Markdown

No description provided.

Comment thread build.sbt Outdated
Comment thread project/plugins.sbt Outdated
addSbtPlugin("com.typesafe.sbt" % "sbt-digest" % "1.1.4")
addSbtPlugin("com.typesafe.sbt" % "sbt-mocha" % "1.1.2")
addSbtPlugin("ch.epfl.scala" % "sbt-web-scalajs-bundler" % "0.13.0")
// addSbtPlugin("ch.epfl.scala" % "sbt-web-scalajs-bundler" % "0.13.0")
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Remove this line?

Comment thread README.md

## Installation

### From prebuilt release in zip file (recommended)
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this option?

Comment thread README.md
- Run `bin/server` (UNIX) or `bin/server.bat` (Windows)
- Browse to http://localhost:9000

### Using a prebuilt docker image
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this option?

Comment thread README.md Outdated
### Running from Source
1. Clone the repository:
```bash
git clone https://github.com/Ayomide-R/quizmaster.git
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to nymanjens/quizmaster

@nymanjens
Copy link
Copy Markdown
Owner

Looks like the CI is failing:

image

@nymanjens
Copy link
Copy Markdown
Owner

I think you fixed the problem :-) , but it uncovered a new one:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants