Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"globby": "^14.1.0",
"happy-dom": "^17.4.4",
"installed-check": "^9.3.0",
"ipx": "^2.1.0",
"ipx": "https://github.com/sgarner/ipx/releases/download/v3.0.4-alpha.feat-format-extension.1/ipx-3.0.4-alpha.feat-format-extension.1.tgz",
"jiti": "2.4.2",
"knip": "^5.46.5",
"nitropack": "^2.11.8",
Expand All @@ -77,7 +77,7 @@
"vue-tsc": "^2.2.8"
},
"optionalDependencies": {
"ipx": "^2.1.0"
"ipx": "https://github.com/sgarner/ipx/releases/download/v3.0.4-alpha.feat-format-extension.1/ipx-3.0.4-alpha.feat-format-extension.1.tgz"
},
"packageManager": "pnpm@10.7.1",
"resolutions": {
Expand Down
1 change: 1 addition & 0 deletions playground/providers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export const providers: Provider[] = [
from: 'Jeremy Thomas',
width: 300,
height: 300,
format: 'webp',
link: 'https://unsplash.com/@jeremythomasphoto?utm_source=unsplash&utm_medium=referral&utm_content=creditCopyText',
},
{
Expand Down
691 changes: 381 additions & 310 deletions pnpm-lock.yaml

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion src/runtime/components/NuxtImg.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import { computed, onMounted, ref, useAttrs } from 'vue'

import { useImage } from '../composables'
import { parseSize } from '../utils'
import { chooseDefaultFormat, getFileExtension, parseSize } from '../utils'
import { prerenderStaticImages } from '../utils/prerender'
import { markFeatureUsage } from '../utils/performance'
import { imgProps, useBaseImage } from './_base'
Expand All @@ -51,6 +51,9 @@ const $img = useImage()

const _base = useBaseImage(props)

const provider = props.provider || $img.options.provider
const isIPX = provider === 'ipx' || provider === 'ipxStatic'

const placeholderLoaded = ref(false)
const imgEl = ref<HTMLImageElement>()

Expand All @@ -68,6 +71,7 @@ const sizes = computed(() => $img.getSizes(props.src!, {
..._base.modifiers.value,
width: parseSize(props.width),
height: parseSize(props.height),
...(isIPX ? { format: chooseDefaultFormat(getFileExtension(props.src)) } : undefined),
},
}))

Expand Down
6 changes: 2 additions & 4 deletions src/runtime/components/NuxtPicture.vue
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import { computed, onMounted, ref, useAttrs } from 'vue'

import { prerenderStaticImages } from '../utils/prerender'
import { markFeatureUsage } from '../utils/performance'
import { getFileExtension } from '../utils'
import { chooseDefaultFormat, getFileExtension } from '../utils'
import { useImage } from '../composables'
import { useBaseImage, pictureProps, baseImageProps } from './_base'

Expand All @@ -54,14 +54,12 @@ const { attrs: baseAttrs, options: baseOptions, modifiers: baseModifiers } = use

const originalFormat = computed(() => getFileExtension(props.src))

const isTransparent = computed(() => ['png', 'webp', 'gif', 'svg'].includes(originalFormat.value))

const legacyFormat = computed(() => {
if (props.legacyFormat) {
return props.legacyFormat
}

return isTransparent.value ? 'png' : 'jpeg'
return chooseDefaultFormat(originalFormat.value)
})

type Source = { src?: string, srcset?: string, type?: string, sizes?: string }
Expand Down
25 changes: 21 additions & 4 deletions src/runtime/providers/ipx.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { joinURL, encodePath, encodeParam } from 'ufo'
import type { ProviderGetImage } from '../../module'
import { createOperationsGenerator } from '#image'
import { createOperationsGenerator, chooseDefaultFormat, getFileExtension } from '#image'

const operationsGenerator = createOperationsGenerator({
keyMap: {
Expand All @@ -23,14 +23,31 @@ export const getImage: ProviderGetImage = (src, { modifiers = {}, baseURL } = {}
delete modifiers.height
}

const params = operationsGenerator(modifiers) || '_'

if (!baseURL) {
baseURL = joinURL(ctx.options.nuxt.baseURL, '/_ipx')
}

let format = modifiers.format

if (format === 'auto' || Object.keys(modifiers).length === 0) {
// Use URL style with modifiers as second path segment: /_ipx/f_auto&s_300x300/source.jpg
const params = operationsGenerator(modifiers) || '_'

return {
url: joinURL(baseURL, params, encodePath(src)),
}
}

if (!format) {
format = chooseDefaultFormat(getFileExtension(src))
}

// Use URL style with modifiers at end of filename, format as extension: /_ipx/~/source.jpg@s_300x300.webp
delete modifiers.format
const params = operationsGenerator(modifiers) || '_'

return {
url: joinURL(baseURL, params, encodePath(src)),
url: joinURL(baseURL, '~', `${encodePath(src)}@@${params}.${format}`),
}
}

Expand Down
13 changes: 13 additions & 0 deletions src/runtime/utils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,19 @@ export function getFileExtension(url = '') {
return extension
}

/**
* Returns a suitable default format to use based on the image's original format.
*/
export function chooseDefaultFormat(originalFormat: string) {
if (originalFormat === 'svg') {
return 'svg'
}

const isTransparent = ['png', 'webp', 'gif'].includes(originalFormat)

return isTransparent ? 'png' : 'jpeg'
}

export function cleanDoubleSlashes(path = '') {
return path.replace(/(https?:\/\/)|(\/)+/g, '$1$2')
}
Expand Down
17 changes: 9 additions & 8 deletions test/e2e/generate.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,15 @@ describe('ipx provider', () => {
expect(files.sort().map(f => f.replace(outputDir, '/_ipx'))).toMatchInlineSnapshot(`
[
"/_ipx/_/images/nuxt.png",
"/_ipx/s_300x300/images/colors.jpg",
"/_ipx/s_300x300/images/everest.jpg",
"/_ipx/s_300x300/images/tacos.svg",
"/_ipx/s_300x300/unsplash/photo-1606112219348-204d7d8b94ee",
"/_ipx/s_600x600/images/colors.jpg",
"/_ipx/s_600x600/images/everest.jpg",
"/_ipx/s_600x600/images/tacos.svg",
"/_ipx/s_600x600/unsplash/photo-1606112219348-204d7d8b94ee",
"/_ipx/~/images/colors.jpg@@s_300x300.jpeg",
"/_ipx/~/images/colors.jpg@@s_300x300.webp",
"/_ipx/~/images/colors.jpg@@s_600x600.jpeg",
"/_ipx/~/images/everest.jpg@@s_300x300.jpeg",
"/_ipx/~/images/everest.jpg@@s_600x600.jpeg",
"/_ipx/~/images/tacos.svg@@s_300x300.svg",
"/_ipx/~/images/tacos.svg@@s_600x600.svg",
"/_ipx/~/unsplash/photo-1606112219348-204d7d8b94ee@@s_300x300.jpeg",
"/_ipx/~/unsplash/photo-1606112219348-204d7d8b94ee@@s_600x600.jpeg",
]
`)
})
Expand Down
10 changes: 5 additions & 5 deletions test/providers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export const images = [
{
args: ['/test.png', { width: 200 }],
none: { url: '/test.png' },
ipx: { url: '/_ipx/w_200/test.png' },
ipx: { url: '/_ipx/~/test.png@@w_200.png' },
aliyun: { url: '/test.png?image_process=resize,w_200' },
awsAmplify: { url: '/?url=%2Ftest.png&w=320&q=100' },
cloudflare: { url: '/cdn-cgi/image/w=200/test.png' },
Expand Down Expand Up @@ -74,7 +74,7 @@ export const images = [
{
args: ['/test.png', { height: 200 }],
none: { url: '/test.png' },
ipx: { url: '/_ipx/h_200/test.png' },
ipx: { url: '/_ipx/~/test.png@@h_200.png' },
aliyun: { url: '/test.png?image_process=resize,h_200' },
awsAmplify: { url: '/?url=%2Ftest.png&h=200&w=1536&q=100' },
cloudflare: { url: '/cdn-cgi/image/h=200/test.png' },
Expand Down Expand Up @@ -110,7 +110,7 @@ export const images = [
{
args: ['/test.png', { width: 200, height: 200 }],
none: { url: '/test.png' },
ipx: { url: '/_ipx/s_200x200/test.png' },
ipx: { url: '/_ipx/~/test.png@@s_200x200.png' },
aliyun: { url: '/test.png?image_process=resize,fw_200,fh_200' },
awsAmplify: { url: '/?url=%2Ftest.png&w=320&h=200&q=100' },
cloudflare: { url: '/cdn-cgi/image/w=200,h=200/test.png' },
Expand Down Expand Up @@ -146,7 +146,7 @@ export const images = [
{
args: ['/test.png', { width: 200, height: 200, fit: 'contain' }],
none: { url: '/test.png' },
ipx: { url: '/_ipx/fit_contain&s_200x200/test.png' },
ipx: { url: '/_ipx/~/test.png@@fit_contain&s_200x200.png' },
aliyun: { url: '/test.png?image_process=fit,contain/resize,fw_200,fh_200' },
awsAmplify: { url: '/?url=%2Ftest.png&w=320&h=200&fit=contain&q=100' },
cloudflare: { url: '/cdn-cgi/image/w=200,h=200,fit=contain/test.png' },
Expand Down Expand Up @@ -182,7 +182,7 @@ export const images = [
{
args: ['/test.png', { width: 200, height: 200, fit: 'contain', format: 'jpeg' }],
none: { url: '/test.png' },
ipx: { url: '/_ipx/fit_contain&f_jpeg&s_200x200/test.png' },
ipx: { url: '/_ipx/~/test.png@@fit_contain&s_200x200.jpeg' },
aliyun: { url: '/test.png?image_process=fit,contain/format,jpeg/resize,fw_200,fh_200' },
awsAmplify: { url: '/?url=%2Ftest.png&w=320&h=200&fit=contain&format=jpeg&q=100' },
cloudflare: { url: '/cdn-cgi/image/w=200,h=200,fit=contain,f=jpeg/test.png' },
Expand Down
Loading
Loading