fix: lodash.reject shadows Promise.reject, deprecated RxJS ops, lodash bundle, triplicated logout logic

[Copilot]

Five code quality and correctness findings: one active bug causing permanently hanging promises, three deprecated RxJS operator usages, a full-bundle lodash import, and triplicated logout logic.

Critical Bug Fix: getToken() Promise Never Rejects

Promise constructor was missing the reject parameter, so the lodash array-filter reject() was called instead — silently returning [] and leaving the promise hanging forever when the token is empty.

// Before — calls lodash.reject(), promise hangs
import { isEqual, reject } from 'lodash-es';
return new Promise<string>(resolve => {
  ...
  reject(new Error('Cannot get DIA backend token which is empty.')); // lodash!
});

// After — correct Promise rejection
import { isEqual } from 'lodash-es';
return new Promise<string>((resolve, reject) => {
  ...
  reject(new Error('Cannot get DIA backend token which is empty.')); // Promise.reject
});

Deprecated RxJS Operators Replaced

Deprecated	Replacement	Files
repeatWhen(() => n$)	repeat({ delay: () => n$ })	dia-backend-asset-repository, dia-backend-transaction-repository, dia-backend-contact-repository
retryWhen(err$ => err$.pipe(mergeMap((_, i) => timer(...))))	retry({ delay: (_, i) => timer(...) })	dia-backend-asset-uploading
pluck('count')	map(x => x.count)	same repos as repeatWhen

Lodash Full-Bundle Import in proof.ts

// Before — pulls entire ~530KB CJS bundle
import { snakeCase } from 'lodash';
// After — tree-shakable
import { snakeCase } from 'lodash-es';

Extracted LogoutService (DRY)

The wipe-and-reload pipeline (mediaStore.clear() → database.clear() → preferenceManager.clear() → reloadApp) was copy-pasted across home.page.ts, capture-tab.component.ts, and settings.page.ts. Extracted into shared/logout/logout.service.ts with:

• wipeAndReload$() — the shared clearing pipeline
• logout$() — confirmation dialog + blocking action wrapper (used by home and capture-tab)
• settings.page.ts deleteAccount() now chains diaBackendAuthService.deleteAccount$() into logoutService.wipeAndReload$()

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• download.cypress.io
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node index.js --exec install conf�� ut-json dist/docs.json --global iptables core.hooksPath (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[numbers-official]

Closing this stale Copilot draft PR. It is outdated against main, not merge-ready, and bundles broad automated changes without current full CI coverage. We should re-open focused PRs only for findings that are still valid after current main/Angular 21.