Fix #1275 accessing egs_glib geometries by ausgab objects - #1405
Open
mchamberland wants to merge 3 commits into
Open
Fix #1275 accessing egs_glib geometries by ausgab objects#1405mchamberland wants to merge 3 commits into
mchamberland wants to merge 3 commits into
Conversation
Preserve egs_glib wrapper naming while registering the included simulation geometry name as an alias for lookup by ausgab objects. Made-with: Cursor
Add egs_glib include geometries and egs_app test inputs that cover internal and wrapper name lookups, label-based region selection, and expected failure paths, plus a runnable test matrix script. Made-with: Cursor
- Replace hardcoded APP_BIN/LIB_DIR with HEN_HOUSE, EGS_CONFIG/EGS_MACHINE, EGS_HOME-derived defaults, and documented env overrides. - Symlink glib_alias *.egsinp and *.geom into $EGS_HOME/egs_app because egs_app resolves -i only under that directory. - Add glib_alias_labels_neg_unknown_label.egsinp under geometry/examples with relative include path for the matrix. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
egs_glibgeometries discoverable by both names:HEN_HOUSE/egs++/geometry/examples, plus a helper script:run_glib_alias_tests.shWhat changed
EGS_BaseGeometryinternals.EGS_BaseGeometry::addGeometryAlias(...).egs_glibegs_glibinclude examples andegs_appinputs for:glib_alias_pos_both)glib_alias_labels_pos)glib_alias_labels_neg_unknown_label; still completes successfully given current fallback behavior)Validation
HEN_HOUSE/egs++/geometry/examples/run_glib_alias_tests.sh:3ddoseoutputs for the positive cases checked.egs_appruns.